gh-196: Make permanent freezing ops use STR.

Closes #196.

Author: python-processing-unit

docs/SPECIFICATION.html

@@ -709,9 +709,9 @@
 
 - `STR SIGNATURE(SYMBOL name)` = MUST return a textual signature for `name`. If `name` denotes a user-defined function, the result MUST use the canonical function-signature form of this specification. For any other visible binding, the result MUST be `TYPE name`.
 
--- `BOOL FREEZE(STR name)`, `BOOL THAW(STR name)`, and `BOOL PERMAFREEZE(SYMBOL name)` = MUST modify the mutability state of the binding designated by `name`. `FREEZE` MUST prevent reassignment and deletion until thawed. `PERMAFREEZE` MUST permanently prevent reassignment, deletion, and later thawing. `THAW` MUST clear a non-permanent freeze, MUST raise a runtime error when applied to a permanently frozen binding, and MUST otherwise succeed as a no-op when applied to a binding that is not currently frozen. `FREEZE`, `THAW`, and `PERMAFREEZE` MUST each return `FALSE` on success and MUST raise a runtime error if `name` is undefined.
+- `BOOL FREEZE(STR name)`, `BOOL THAW(STR name)`, and `BOOL PERMAFREEZE(STR name)` = MUST modify the mutability state of the binding designated by `name`. `FREEZE` MUST prevent reassignment and deletion until thawed. `PERMAFREEZE` MUST permanently prevent reassignment, deletion, and later thawing. `THAW` MUST clear a non-permanent freeze, MUST raise a runtime error when applied to a permanently frozen binding, and MUST otherwise succeed as a no-op when applied to a binding that is not currently frozen. `FREEZE`, `THAW`, and `PERMAFREEZE` MUST each return `FALSE` on success and MUST raise a runtime error if `name` is undefined.
 
--- `BOOL FROZEN(STR name)` and `BOOL PERMAFROZEN(SYMBOL name)` = MUST report the freeze state of `name`. `FROZEN` MUST return `TRUE` for any frozen or permanently frozen binding and `FALSE` otherwise. `PERMAFROZEN` MUST return `TRUE` only for permanently frozen bindings and `FALSE` otherwise. If `name` is undefined, both operators MUST return `FALSE`.
+- `BOOL FROZEN(STR name)` and `BOOL PERMAFROZEN(STR name)` = MUST report the freeze state of `name`. `FROZEN` MUST return `TRUE` for any frozen or permanently frozen binding and `FALSE` otherwise. `PERMAFROZEN` MUST return `TRUE` only for permanently frozen bindings and `FALSE` otherwise. If `name` is undefined, both operators MUST return `FALSE`.
 
 ---
 

src/builtins.c

@@ -8568,11 +8568,12 @@ static Value builtin_thaw(Interpreter *interp, Value *args, int argc, Expr **arg
 
 static Value builtin_permafreeze(Interpreter *interp, Value *args, int argc, Expr **arg_nodes, Env *env, int line,
                                  int col) {
-    (void)args;
-    if (argc != 1 || arg_nodes[0]->type != EXPR_IDENT) {
-        RUNTIME_ERROR(interp, "PERMAFREEZE expects an identifier", line, col);
+    (void)arg_nodes;
+    if (argc != 1) {
+        RUNTIME_ERROR(interp, "PERMAFREEZE expects 1 argument", line, col);
     }
-    const char *name = arg_nodes[0]->as.ident;
+    EXPECT_STR(args[0], "PERMAFREEZE", interp, line, col);
+    const char *name = args[0].as.s ? args[0].as.s : "";
     int r = env_permafreeze(env, name);
     if (r != 0) {
         char buf[128];
@@ -8663,11 +8664,12 @@ static Value builtin_frozen(Interpreter *interp, Value *args, int argc, Expr **a
 
 static Value builtin_permafrozen(Interpreter *interp, Value *args, int argc, Expr **arg_nodes, Env *env, int line,
                                  int col) {
-    (void)args;
-    if (argc != 1 || arg_nodes[0]->type != EXPR_IDENT) {
-        RUNTIME_ERROR(interp, "PERMAFROZEN expects an identifier", line, col);
+    (void)arg_nodes;
+    if (argc != 1) {
+        RUNTIME_ERROR(interp, "PERMAFROZEN expects 1 argument", line, col);
     }
-    const char *name = arg_nodes[0]->as.ident;
+    EXPECT_STR(args[0], "PERMAFROZEN", interp, line, col);
+    const char *name = args[0].as.s ? args[0].as.s : "";
     int p = env_permafrozen(env, name);
     return value_bool(p != 0);
 }

tests/cases/passing/del-frozen.pre

@@ -15,7 +15,7 @@ REFUTE(DEL("frozen_symbol"))
 REFUTE(EXIST("frozen_symbol"))
 
 BOOL permafrozen_symbol = TRUE
-REFUTE(PERMAFREEZE(permafrozen_symbol))
+REFUTE(PERMAFREEZE("permafrozen_symbol"))
 
 BOOL permafrozen_delete_failed = FALSE
 TRY{

tests/cases/passing/freeze.pre

@@ -2,7 +2,7 @@ BOOL frozen_value = TRUE
 
 REFUTE(FREEZE("frozen_value"))
 ASSERT(FROZEN("frozen_value"))
-REFUTE(PERMAFROZEN(frozen_value))
+REFUTE(PERMAFROZEN("frozen_value"))
 
 BOOL freeze_undefined_failed = FALSE
 TRY{

tests/cases/passing/frozen.pre

@@ -6,6 +6,6 @@ ASSERT(FROZEN("normal_value"))
 REFUTE(THAW("normal_value"))
 REFUTE(FROZEN("normal_value"))
 
-REFUTE(PERMAFREEZE(normal_value))
+REFUTE(PERMAFREEZE("normal_value"))
 ASSERT(FROZEN("normal_value"))
-ASSERT(PERMAFROZEN(normal_value))
+ASSERT(PERMAFROZEN("normal_value"))

tests/cases/passing/permafreeze.pre

@@ -1,12 +1,12 @@
 BOOL locked_value = TRUE
 
-REFUTE(PERMAFREEZE(locked_value))
+REFUTE(PERMAFREEZE("locked_value"))
 ASSERT(FROZEN("locked_value"))
-ASSERT(PERMAFROZEN(locked_value))
+ASSERT(PERMAFROZEN("locked_value"))
 
 BOOL permafreeze_undefined_failed = FALSE
 TRY{
-    PERMAFREEZE(not_declared)
+    PERMAFREEZE("not_declared")
 } CATCH {
     permafreeze_undefined_failed = TRUE
 }
@@ -37,4 +37,4 @@ TRY{
     thaw_failed = TRUE
 }
 ASSERT(thaw_failed)
-ASSERT(PERMAFROZEN(locked_value))
+ASSERT(PERMAFROZEN("locked_value"))

tests/cases/passing/permafrozen.pre

@@ -1,6 +1,6 @@
 BOOL normal_value = TRUE
-REFUTE(PERMAFROZEN(normal_value))
+REFUTE(PERMAFROZEN("normal_value"))
 
-REFUTE(PERMAFREEZE(normal_value))
-ASSERT(PERMAFROZEN(normal_value))
+REFUTE(PERMAFREEZE("normal_value"))
+ASSERT(PERMAFROZEN("normal_value"))
 ASSERT(FROZEN("normal_value"))