chore: checker also checks for criticatl statuses

Author: azmeuk

scim2_tester/utils.py

@@ -267,13 +267,16 @@ def wrapped(context: CheckContext, *args: Any, **kwargs: Any) -> Any:
 
             # Check for ERROR results and raise SCIMTesterError if configured
             if context.conf.raise_exceptions:
-                if isinstance(result, CheckResult) and result.status == Status.ERROR:
+                if isinstance(result, CheckResult) and result.status in (
+                    Status.ERROR,
+                    Status.CRITICAL,
+                ):
                     raise SCIMTesterError(result.reason or "Check failed", context.conf)
                 elif isinstance(result, list):
                     errors = [
                         SCIMTesterError(r.reason or "Check failed", context.conf)
                         for r in result
-                        if r.status == Status.ERROR
+                        if r.status in (Status.ERROR, Status.CRITICAL)
                     ]
                     if len(errors) == 1:
                         raise errors[0]

tests/test_scim2_server.py

@@ -16,7 +16,9 @@ def test_discovered_scim2_server(scim2_server_app):
 
     executed_results = [r for r in results if r.status != Status.SKIPPED]
     assert len(executed_results) > 0
-    assert all(r.status in (Status.SUCCESS, Status.ERROR) for r in executed_results)
+    assert all(
+        r.status not in (Status.ERROR, Status.CRITICAL) for r in executed_results
+    )
 
 
 def test_undiscovered_scim2_server(scim2_server_app):
@@ -26,7 +28,9 @@ def test_undiscovered_scim2_server(scim2_server_app):
 
     executed_results = [r for r in results if r.status != Status.SKIPPED]
     assert len(executed_results) > 0
-    assert all(r.status in (Status.SUCCESS, Status.ERROR) for r in executed_results)
+    assert all(
+        r.status not in (Status.ERROR, Status.CRITICAL) for r in executed_results
+    )
 
 
 @pytest.mark.parametrize("tag", get_all_available_tags())
@@ -36,10 +40,10 @@ def test_individual_filters(scim2_server_app, tag, resource_type):
     client = TestSCIMClient(Client(scim2_server_app))
     client.discover()
     results = check_server(
-        client, raise_exceptions=False, include_tags={tag}, resource_types=resource_type
+        client, raise_exceptions=True, include_tags={tag}, resource_types=resource_type
     )
     for result in results:
-        assert result.status in (Status.SKIPPED, Status.SUCCESS), (
+        assert result.status not in (Status.ERROR, Status.CRITICAL), (
             f"Result {result.title} failed: {result.reason}"
         )