Skip to content

Get coverage back to 100%#3268

Merged
jakkdl merged 2 commits into
python-trio:mainfrom
A5rocks:coverage-back-to-100
May 15, 2025
Merged

Get coverage back to 100%#3268
jakkdl merged 2 commits into
python-trio:mainfrom
A5rocks:coverage-back-to-100

Conversation

@A5rocks
Copy link
Copy Markdown
Contributor

@A5rocks A5rocks commented May 14, 2025

This fixes coverage losses in #3234

@A5rocks A5rocks added the skip newsfragment Newsfragment is not required label May 14, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00000%. Comparing base (bb63c53) to head (b29f270).
⚠️ Report is 51 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                  @@
##                main        #3268         +/-   ##
====================================================
+ Coverage   99.93728%   100.00000%   +0.06271%     
====================================================
  Files            126          127          +1     
  Lines          19132        20737       +1605     
  Branches        1296         1517        +221     
====================================================
+ Hits           19120        20737       +1617     
+ Misses            10            0         -10     
+ Partials           2            0          -2     
Files with missing lines Coverage Δ
src/trio/_tests/tools/test_sync_requirements.py 100.00000% <ø> (ø)
src/trio/_tools/gen_exports.py 100.00000% <ø> (ø)
src/trio/_tools/mypy_annotate.py 100.00000% <ø> (ø)
src/trio/_tools/sync_requirements.py 100.00000% <ø> (+21.42856%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jakkdl
Copy link
Copy Markdown
Member

jakkdl commented May 15, 2025

huh, why didn't CI block <100%?

EDIT: I guess blocking merging on <100% coverage might be a bit harsh, although we could possibly recreate the skip-newsfragment label setup. But it's probably fine either way

@A5rocks
Copy link
Copy Markdown
Contributor Author

A5rocks commented May 15, 2025

I think we have CI set up to allow codecov failures because of it being flakey

@jakkdl
Copy link
Copy Markdown
Member

jakkdl commented May 15, 2025

I think we have CI set up to allow codecov failures because of it being flakey

I don't think it's flakey with current setup, but fair enough.

Comment thread pyproject.toml
@jakkdl jakkdl merged commit 0209a18 into python-trio:main May 15, 2025
41 of 43 checks passed
@A5rocks A5rocks deleted the coverage-back-to-100 branch June 9, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newsfragment Newsfragment is not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants