unpin cython#3269
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3269 +/- ##
===============================================
Coverage 100.00000% 100.00000%
===============================================
Files 127 127
Lines 19259 19259
Branches 1301 1301
===============================================
Hits 19259 19259 🚀 New features to boost your workflow:
|
|
ah, I simply needed setuptools. The tox env isn't super pretty but I'm not sure it's worth trying to merge with the regular cython env, but it might be useful for testing / in the future if/when we integrate tox into CI. |
| commands = | ||
| python -m tests.cython.run_test_cython | ||
|
|
||
| [testenv:cov-cython] |
There was a problem hiding this comment.
I would rather either have this in CI or delay this part of this PR until that point, so it doesn't get stale.
There was a problem hiding this comment.
that logic would apply to everything in this file, and I think keeping it lowers the barrier to incorporating it to CI when that day comes around even if it does become stale
There was a problem hiding this comment.
Well not the typing things! But alright, fine.
CoolCat467
left a comment
CoolCat467
left a comment
There was a problem hiding this comment.
Other than the new cov-cython stuff, this looks good
webknjaz
left a comment
webknjaz
left a comment
There was a problem hiding this comment.
Sorry, I've been busy at PyCon US sprints and couldn't find time to look into this. I think I've found a typo, though.
| setuptools | ||
| cython | ||
| set_env = | ||
| CFLAGS= -DCYTHON_TRACE_NOGIL=1A |
There was a problem hiding this comment.
oops, yeah that should be a 1 🙏
|
@jakkdl I have a new |
4 participants
fixes part of #3267 with the release of https://github.com/cython/cython/releases/tag/3.1.1
I'm getting errors locally when I try to combine it with coverage, so I think there's more to be done, but let's see if CI errors as well
I did look at configuration options for coverage and tox and ultimately couldn't find a better option than
sedingpyproject.toml(as the CI setup does), though at least did it to a copy in the tox tmp/ directory to not screw with the git working tree.