Skip to content

refactor(bootstrapper): apply review follow-ups to _cache module#1248

Open
dhellmann wants to merge 1 commit into
python-wheel-build:mainfrom
dhellmann:task-specific-work-items-follow-ups
Open

refactor(bootstrapper): apply review follow-ups to _cache module#1248
dhellmann wants to merge 1 commit into
python-wheel-build:mainfrom
dhellmann:task-specific-work-items-follow-ups

Conversation

@dhellmann

Copy link
Copy Markdown
Member

Add docstring to Bootstrapper class describing it as an iterative DFS engine to be used as a context manager.

Rename private _cache functions that cross module boundaries to drop the leading underscore, reflecting their role as internal-but-public APIs within the bootstrapper package:

  • _find_cached_wheelfind_cached_wheel
  • _bg_prepare_prebuiltbg_prepare_prebuilt

Update all call sites in _bootstrapper.py, _prepare_source.py, _resolve.py, and tests.

Add docstring to `Bootstrapper` class describing it as an iterative DFS
engine to be used as a context manager.

Rename private `_cache` functions that cross module boundaries to drop
the leading underscore, reflecting their role as internal-but-public
APIs within the bootstrapper package:

- `_find_cached_wheel` → `find_cached_wheel`
- `_bg_prepare_prebuilt` → `bg_prepare_prebuilt`

Update all call sites in `_bootstrapper.py`, `_prepare_source.py`,
`_resolve.py`, and tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann requested a review from a team as a code owner July 10, 2026 21:30
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The cache helpers _find_cached_wheel and _bg_prepare_prebuilt were renamed to find_cached_wheel and bg_prepare_prebuilt. Bootstrapper, source preparation, and resolution code now use the renamed helpers. Existing tests and patch targets were updated accordingly. The Bootstrapper class also gained a docstring describing its iterative DFS behavior and context-manager flow.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title matches the main changes: bootstrapper follow-ups and _cache API renames.
Description check ✅ Passed The description accurately summarizes the docstring addition and cross-module cache helper renames.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Jul 10, 2026

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks

@mergify

mergify Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants