Skip to content

Fix diagram in README.md #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 4 commits into from May 25, 2025
Merged

Fix diagram in README.md #664

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02c16ab
Fix line breaks in diagram
May 4, 2025
26684eb
Fix arrow styles in diagram
May 4, 2025
462e609
Update README.md
May 18, 2025
0eb91c5
Change `<br/>` to `<br>`
May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,18 @@ flowchart TD
A_draft -- publish draft by contributor --> A:::creator
A -- by contributor --> B[Awaiting review]:::anyone
A -- by core dev --> C[Awaiting core review]:::coredev
B & C -- new review by\nanother contributor --> C
C & B & E -- new core review\nrequests changes --> D[Awaiting changes]:::creator
B & C -- new review by<br/>another contributor --> C
C & B & E -- new core review<br/>requests changes --> D[Awaiting changes]:::creator
Copy link
Copy Markdown
Member

@ezio-melotti ezio-melotti May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does <br> (without /) work too?

I'm pretty sure that \ns used to work, I wonder if they changed it in a recent update.

Copy link
Copy Markdown
Author

@ghost ghost May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezio-melotti <br> also works. The example of the mermaid document uses both.

Copy link
Copy Markdown
Member

@hugovk hugovk May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use <br> then :)

D -- changes by contributor --> E[Awaiting change review]:::coredev
C & E & B -- new core review\napproves ---> F[Awaiting merge]:::coredev
G[When a review is dismissed\nthe highest remaining state is restored\nbased on the remaining reviews]
C & E & B -- new core review<br/>approves ---> F[Awaiting merge]:::coredev
G[When a review is dismissed<br/>the highest remaining state is restored<br/>based on the remaining reviews]
classDef creator stroke:#CC0;
classDef anyone stroke:#00C;
classDef coredev stroke:#0C0;
classDef triager stroke:#C0C;
linkStyle 0,1,7 stroke:#CC0,color:auto;
linkStyle 2,3 stroke:#00C,color:auto;
linkStyle 4,5,6,8,9,10 stroke:#0C0,color:auto;
linkStyle 0,1,8 stroke:#CC0,color:auto;
linkStyle 3,4 stroke:#00C,color:auto;
linkStyle 2,5,6,7,9,10,11 stroke:#0C0,color:auto;
```

## *Aside*: where does the name come from?
Expand Down
Loading