Skip to content

Commit 38eaec2

Browse files
committed
fixup! Move 'blurb add' to blurb._add
1 parent 83ef57c commit 38eaec2

1 file changed

Lines changed: 21 additions & 19 deletions

File tree

tests/test_blurb_add.py

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,14 @@
22

33
import pytest
44

5-
from blurb import blurb
6-
5+
import blurb._add
6+
import blurb._template
7+
from blurb._add import (_blurb_template_text, _extract_issue_number,
8+
_extract_section_name)
79

810
def test_valid_no_issue_number():
9-
assert blurb._extract_issue_number(None) is None
10-
res = blurb._blurb_template_text(issue=None, section=None)
11+
assert _extract_issue_number(None) is None
12+
res = _blurb_template_text(issue=None, section=None)
1113
lines = frozenset(res.splitlines())
1214
assert '.. gh-issue:' not in lines
1315
assert '.. gh-issue: ' in lines
@@ -34,10 +36,10 @@ def test_valid_no_issue_number():
3436
' https://github.com/python/cpython/issues/12345 ',
3537
))
3638
def test_valid_issue_number_12345(issue):
37-
actual = blurb._extract_issue_number(issue)
39+
actual = _extract_issue_number(issue)
3840
assert actual == 12345
3941

40-
res = blurb._blurb_template_text(issue=issue, section=None)
42+
res = _blurb_template_text(issue=issue, section=None)
4143
lines = frozenset(res.splitlines())
4244
assert '.. gh-issue:' not in lines
4345
assert '.. gh-issue: ' not in lines
@@ -70,7 +72,7 @@ def test_valid_issue_number_12345(issue):
7072
def test_invalid_issue_number(issue):
7173
error_message = re.escape(f'Invalid GitHub issue number: {issue}')
7274
with pytest.raises(SystemExit, match=error_message):
73-
blurb._blurb_template_text(issue=issue, section=None)
75+
_blurb_template_text(issue=issue, section=None)
7476

7577

7678
@pytest.mark.parametrize('invalid', (
@@ -79,21 +81,21 @@ def test_invalid_issue_number(issue):
7981
'gh-issue',
8082
))
8183
def test_malformed_gh_issue_line(invalid, monkeypatch):
82-
template = blurb.template.replace('.. gh-issue:', invalid)
84+
template = blurb._add.template.replace('.. gh-issue:', invalid)
8385
error_message = re.escape("Can't find gh-issue line in the template!")
8486
with monkeypatch.context() as cm:
85-
cm.setattr(blurb, 'template', template)
87+
cm.setattr(blurb._add, 'template', template)
8688
with pytest.raises(SystemExit, match=error_message):
87-
blurb._blurb_template_text(issue='1234', section=None)
89+
_blurb_template_text(issue='1234', section=None)
8890

8991

9092
def _check_section_name(section_name, expected):
91-
actual = blurb._extract_section_name(section_name)
93+
actual = _extract_section_name(section_name)
9294
assert actual == expected
9395

94-
res = blurb._blurb_template_text(issue=None, section=section_name)
96+
res = _blurb_template_text(issue=None, section=section_name)
9597
res = res.splitlines()
96-
for section_name in blurb.sections:
98+
for section_name in blurb._template.sections:
9799
if section_name == expected:
98100
assert f'.. section: {section_name}' in res
99101
else:
@@ -103,15 +105,15 @@ def _check_section_name(section_name, expected):
103105

104106
@pytest.mark.parametrize(
105107
('section_name', 'expected'),
106-
[(name, name) for name in blurb.sections],
108+
[(name, name) for name in blurb._template.sections],
107109
)
108110
def test_exact_names(section_name, expected):
109111
_check_section_name(section_name, expected)
110112

111113

112114
@pytest.mark.parametrize(
113115
('section_name', 'expected'),
114-
[(name.lower(), name) for name in blurb.sections],
116+
[(name.lower(), name) for name in blurb._template.sections],
115117
)
116118
def test_exact_names_lowercase(section_name, expected):
117119
_check_section_name(section_name, expected)
@@ -128,10 +130,10 @@ def test_exact_names_lowercase(section_name, expected):
128130
def test_empty_section_name(section):
129131
error_message = re.escape('Empty section name!')
130132
with pytest.raises(SystemExit, match=error_message):
131-
blurb._extract_section_name(section)
133+
_extract_section_name(section)
132134

133135
with pytest.raises(SystemExit, match=error_message):
134-
blurb._blurb_template_text(issue=None, section=section)
136+
_blurb_template_text(issue=None, section=section)
135137

136138

137139
@pytest.mark.parametrize('section', [
@@ -157,7 +159,7 @@ def test_empty_section_name(section):
157159
def test_invalid_section_name(section):
158160
error_message = rf"(?m)Invalid section name: '{re.escape(section)}'\n\n.+"
159161
with pytest.raises(SystemExit, match=error_message):
160-
blurb._extract_section_name(section)
162+
_extract_section_name(section)
161163

162164
with pytest.raises(SystemExit, match=error_message):
163-
blurb._blurb_template_text(issue=None, section=section)
165+
_blurb_template_text(issue=None, section=section)

0 commit comments

Comments
 (0)