Skip to content

Commit 1a08565

Browse files
Use Savannah's much better and shorter description
Co-authored-by: Savannah Ostrowski <savannah@python.org>
1 parent 390cc8a commit 1a08565

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

Tools/jit/_llvm.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,14 +46,10 @@ async def _run(tool: str, args: typing.Iterable[str], echo: bool = False) -> str
4646
if os.name == "nt":
4747
env = os.environ.copy()
4848
try:
49-
# https://github.com/python/cpython/issues/146210
50-
# When the Python iterpreter is built with
51-
# "/p:PlatformToolset=ClangCL" "/p:LLVMInstallDir=...""
52-
# msbuild populates the INCLUDE variable based on this
53-
# clang version, which might be different to the one used
54-
# for building the jit stencils. Mixing those include paths
55-
# can cause mysterious build errors, so we remove the
56-
# variable from the environment when invoking LLVM tools.
49+
# When building with /p:PlatformToolset=ClangCL, the VS build
50+
# system puts that clang's include path into INCLUDE. The JIT's
51+
# clang may be a different version, and mismatched headers cause
52+
# build errors. See https://github.com/python/cpython/issues/146210
5753
del env["INCLUDE"]
5854
except KeyError:
5955
pass

0 commit comments

Comments
 (0)