Skip to content

Commit 36764cb

Browse files
Fix display name consistency in flamegraph toggle
Rename "Full Paths" to "File Paths", remove basename-only .split('/').pop() so tooltip, hotspots, and search all show the same path in file-paths mode.
1 parent 26b4f18 commit 36764cb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

Lib/profiling/sampling/_flamegraph_assets/flamegraph.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ function getDisplayName(moduleName, filename) {
9595
if (useModuleNames) {
9696
return moduleName || filename;
9797
}
98-
return filename ? filename.split('/').pop() : filename;
98+
return filename;
9999
}
100100

101101
function selectFlamegraphData() {

Lib/profiling/sampling/_flamegraph_assets/flamegraph_template.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ <h3 class="section-title">View Mode</h3>
118118
</div>
119119

120120
<div class="toggle-switch" id="toggle-path-display" title="Toggle between module names and full file paths" tabindex="0">
121-
<span class="toggle-label" data-text="Full Paths">Full Paths</span>
121+
<span class="toggle-label" data-text="File Paths">File Paths</span>
122122
<div class="toggle-track on"></div>
123123
<span class="toggle-label active" data-text="Module Names">Module Names</span>
124124
</div>

Lib/test/test_profiling/test_sampling_profiler/test_collectors.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -435,14 +435,14 @@ def test_flamegraph_collector_basic(self):
435435
strings = data.get("strings", [])
436436
name = resolve_name(data, strings)
437437
self.assertTrue(name.startswith("Program Root: "))
438-
self.assertIn("func2 (file:20)", name)
438+
self.assertIn("func2 (file.py:20)", name)
439439
label = strings[data["label"]]
440440
self.assertTrue(label.startswith("Program Root: "))
441441
self.assertEqual(data["self"], 0) # non-leaf: no self time
442442
children = data.get("children", [])
443443
self.assertEqual(len(children), 1)
444444
child = children[0]
445-
self.assertIn("func1 (file:10)", resolve_name(child, strings))
445+
self.assertIn("func1 (file.py:10)", resolve_name(child, strings))
446446
self.assertEqual(child["value"], 1)
447447
self.assertEqual(child["self"], 1) # leaf: all time is self
448448

0 commit comments

Comments
 (0)