Skip to content

Commit 614078f

Browse files
committed
gh-137586: Rename MacOSX to MacOS
1 parent bdfc2e6 commit 614078f

File tree

3 files changed

+22
-22
lines changed

3 files changed

+22
-22
lines changed

Doc/library/webbrowser.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -206,15 +206,15 @@ Notes:
206206
Only on iOS.
207207

208208
.. deprecated:: 3.14
209-
:class:`!MacOSXOSAScript` is deprecated in favour of :class:`!MacOSX`.
209+
:class:`!MacOSXOSAScript` is deprecated in favour of :class:`!MacOS`.
210210
Using :program:`/usr/bin/open` instead of :program:`osascript` is a
211211
security and usability improvement: :program:`osascript` may be blocked
212212
on managed systems due to its abuse potential as a general-purpose
213213
scripting interpreter.
214214

215215
.. versionadded:: 3.2
216216
A new :class:`!MacOSXOSAScript` class has been added
217-
and is used on Mac instead of the previous :class:`!MacOSX` class.
217+
and is used on Mac instead of the previous :class:`!MacOS` class.
218218
This adds support for opening browsers not currently set as the OS default.
219219

220220
.. versionadded:: 3.3

Lib/test/test_webbrowser.py

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -326,16 +326,16 @@ def close(self):
326326

327327
@unittest.skipUnless(sys.platform == "darwin", "macOS specific test")
328328
@requires_subprocess()
329-
class MacOSXTest(unittest.TestCase):
329+
class MacOSTest(unittest.TestCase):
330330

331331
def test_default(self):
332332
browser = webbrowser.get()
333-
self.assertIsInstance(browser, webbrowser.MacOSX)
333+
self.assertIsInstance(browser, webbrowser.MacOS)
334334
self.assertEqual(browser.name, 'default')
335335

336336
def test_default_http_open(self):
337337
# http/https URLs use /usr/bin/open directly — no bundle ID needed.
338-
browser = webbrowser.MacOSX('default')
338+
browser = webbrowser.MacOS('default')
339339
with mock.patch('subprocess.run') as mock_run:
340340
mock_run.return_value = mock.Mock(returncode=0)
341341
result = browser.open(URL)
@@ -349,7 +349,7 @@ def test_default_non_http_uses_bundle_id(self):
349349
# Non-http(s) URLs (e.g. file://) must be routed through the browser
350350
# via -b <bundle-id> to prevent OS file handler dispatch.
351351
file_url = 'file:///tmp/test.html'
352-
browser = webbrowser.MacOSX('default')
352+
browser = webbrowser.MacOS('default')
353353
with mock.patch('webbrowser._macos_default_browser_bundle_id',
354354
return_value='com.apple.Safari'), \
355355
mock.patch('subprocess.run') as mock_run:
@@ -364,7 +364,7 @@ def test_default_non_http_uses_bundle_id(self):
364364
def test_default_non_http_fallback_when_no_bundle_id(self):
365365
# If the bundle ID lookup fails, fall back to /usr/bin/open without -b.
366366
file_url = 'file:///tmp/test.html'
367-
browser = webbrowser.MacOSX('default')
367+
browser = webbrowser.MacOS('default')
368368
with mock.patch('webbrowser._macos_default_browser_bundle_id',
369369
return_value=None), \
370370
mock.patch('subprocess.run') as mock_run:
@@ -377,7 +377,7 @@ def test_default_non_http_fallback_when_no_bundle_id(self):
377377

378378
def test_named_known_browser_uses_bundle_id(self):
379379
# Named browsers with a known bundle ID use /usr/bin/open -b.
380-
browser = webbrowser.MacOSX('safari')
380+
browser = webbrowser.MacOS('safari')
381381
with mock.patch('subprocess.run') as mock_run:
382382
mock_run.return_value = mock.Mock(returncode=0)
383383
result = browser.open(URL)
@@ -389,7 +389,7 @@ def test_named_known_browser_uses_bundle_id(self):
389389

390390
def test_named_unknown_browser_falls_back_to_dash_a(self):
391391
# Named browsers not in the bundle ID map fall back to -a.
392-
browser = webbrowser.MacOSX('lynx')
392+
browser = webbrowser.MacOS('lynx')
393393
with mock.patch('subprocess.run') as mock_run:
394394
mock_run.return_value = mock.Mock(returncode=0)
395395
browser.open(URL)
@@ -399,7 +399,7 @@ def test_named_unknown_browser_falls_back_to_dash_a(self):
399399
)
400400

401401
def test_open_failure(self):
402-
browser = webbrowser.MacOSX('default')
402+
browser = webbrowser.MacOS('default')
403403
with mock.patch('subprocess.run') as mock_run:
404404
mock_run.return_value = mock.Mock(returncode=1)
405405
result = browser.open(URL)
@@ -412,7 +412,7 @@ class MacOSXOSAScriptDeprecationTest(unittest.TestCase):
412412

413413
def test_deprecation_warning(self):
414414
with self.assertWarns(DeprecationWarning):
415-
webbrowser.MacOSXOSAScript('default')
415+
webbrowser.MacOSOSAScript('default')
416416

417417

418418
@unittest.skipUnless(sys.platform == "darwin", "macOS specific test")
@@ -428,7 +428,7 @@ def setUp(self):
428428
support.patch(self, os, "popen", self.mock_popen)
429429
self.enterContext(warnings.catch_warnings())
430430
warnings.simplefilter("ignore", DeprecationWarning)
431-
self.browser = webbrowser.MacOSXOSAScript("default")
431+
self.browser = webbrowser.MacOSOSAScript("default")
432432

433433
def mock_popen(self, cmd, mode):
434434
self.popen_pipe = MockPopenPipe(cmd, mode)
@@ -462,7 +462,7 @@ def test_default_browser_lookup(self):
462462
def test_explicit_browser(self):
463463
with warnings.catch_warnings():
464464
warnings.simplefilter("ignore", DeprecationWarning)
465-
browser = webbrowser.MacOSXOSAScript("safari")
465+
browser = webbrowser.MacOSOSAScript("safari")
466466
browser.open("https://python.org")
467467
script = self.popen_pipe.pipe.getvalue()
468468
self.assertIn('tell application "safari"', script)

Lib/webbrowser.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -491,13 +491,13 @@ def register_standard_browsers():
491491
_tryorder = []
492492

493493
if sys.platform == 'darwin':
494-
register("MacOSX", None, MacOSX('default'))
495-
register("chrome", None, MacOSX('google chrome'))
496-
register("chromium", None, MacOSX('chromium'))
497-
register("firefox", None, MacOSX('firefox'))
498-
register("safari", None, MacOSX('safari'))
499-
register("opera", None, MacOSX('opera'))
500-
register("microsoft-edge", None, MacOSX('microsoft edge'))
494+
register("MacOS", None, MacOS('default'))
495+
register("chrome", None, MacOS('google chrome'))
496+
register("chromium", None, MacOS('chromium'))
497+
register("firefox", None, MacOS('firefox'))
498+
register("safari", None, MacOS('safari'))
499+
register("opera", None, MacOS('opera'))
500+
register("microsoft-edge", None, MacOS('microsoft edge'))
501501
# macOS can use below Unix support (but we prefer using the macOS
502502
# specific stuff)
503503

@@ -639,7 +639,7 @@ def _macos_default_browser_bundle_id():
639639
pass
640640
return None
641641

642-
class MacOSX(BaseBrowser):
642+
class MacOS(BaseBrowser):
643643
"""Launcher class for macOS browsers, using /usr/bin/open.
644644
645645
For http/https URLs with the default browser, /usr/bin/open is called
@@ -690,7 +690,7 @@ class MacOSXOSAScript(BaseBrowser):
690690
def __init__(self, name='default'):
691691
import warnings
692692
warnings.warn(
693-
"MacOSXOSAScript is deprecated, use MacOSX instead.",
693+
"MacOSXOSAScript is deprecated, use MacOS instead.",
694694
DeprecationWarning,
695695
stacklevel=2,
696696
)

0 commit comments

Comments
 (0)