Review conf_sharedlib.py: fix docstring and MACOSX_DEPLOYMENT_TARGET parsing.

Fix docstring (perf trampoline lives in conf_buildopts.py, not here).
Add pyconf.is_digit() / pyconf_is_digit() so the deployment target
version components can be validated before int() conversion, matching
autoconf's silent-failure behaviour when the variable is empty or
non-numeric.  Register is_digit in the transpiler lint whitelist.

Assisted-by: Claude

Author: nascheme

Tools/configure/conf_sharedlib.py

@@ -1,10 +1,10 @@
-"""conf_sharedlib — Shared-lib linking, perf trampoline.
+"""conf_sharedlib — Shared-lib linking and dynamic loading.
 
 Determines shared library extension (SHLIB_SUFFIX); computes LDSHARED,
 LDCXXSHARED, BLDSHARED for each platform; sets CCSHARED (-fPIC etc.);
 determines LINKFORSHARED for the main executable; exports shared-lib
-variables (CFLAGSFORSHARED, SHLIBS); and configures perf trampoline
-support.
+variables (CFLAGSFORSHARED, SHLIBS); selects DYNLOADFILE; and sets
+MACHDEP_OBJS.
 """
 
 from __future__ import annotations
@@ -87,8 +87,16 @@ def setup_ldshared(v):
             # This allows an extension to be used in any Python
             dt = v.MACOSX_DEPLOYMENT_TARGET or ""
             dt_parts = dt.split(".")
-            dt_major = int(dt_parts[0]) if dt_parts else 0
-            dt_minor = int(dt_parts[1]) if len(dt_parts) > 1 else 0
+            dt_major = (
+                int(dt_parts[0])
+                if dt_parts and pyconf.is_digit(dt_parts[0])
+                else 0
+            )
+            dt_minor = (
+                int(dt_parts[1])
+                if len(dt_parts) > 1 and pyconf.is_digit(dt_parts[1])
+                else 0
+            )
             if dt_major == 10 and dt_minor <= 2:
                 pyconf.error(
                     f"MACOSX_DEPLOYMENT_TARGET too old ({dt}), "

Tools/configure/configure.awk

@@ -799,14 +799,18 @@ function pyconf_check_func(fname, headers, define, source, inc, cv, rc, cache_ke
         return rc
 }
 
-function pyconf_check_funcs(funcs, n, i, rc) {
+function pyconf_check_funcs(funcs,    n, i, rc, any_found) {
+        # Returns 1 if any function was found (mirrors AC_CHECK_FUNCS action-if-found).
         n = funcs[0] + 0
+        any_found = 0
         for (i = 1; i <= n; i++)
                 if (funcs[i] != "") {
                         pyconf_checking("for " funcs[i])
                         rc = pyconf_check_func(funcs[i])
                         pyconf_result(rc ? "yes" : "no")
+                        if (rc) any_found = 1
                 }
+        return any_found
 }
 
 function pyconf_replace_funcs(funcs, n, i, rc) {
@@ -1227,6 +1231,10 @@ function pyconf_find_mkdir_p(    result, ver, dirs, n, i, p, prog, progs, cmd) {
 # String / path utilities
 # ---------------------------------------------------------------------------
 
+function pyconf_is_digit(s) {
+        return s ~ /^[0-9]+$/
+}
+
 function pyconf_fnmatch(string, pattern) {
         # Simple glob match using case
         # For exact match patterns, use == comparison
@@ -7624,8 +7632,8 @@ function u_setup_ldshared(    _tmp_split, dt, dt_major, dt_minor, dt_parts, has_
         } else if (_str_startswith(sr, "Darwin/")) {
             dt = ((V["MACOSX_DEPLOYMENT_TARGET"] != "") ? V["MACOSX_DEPLOYMENT_TARGET"] : "")
             dt_parts = _str_replace(dt, ".", " ")
-            dt_major = (((dt_parts != "") && (dt_parts != "no")) ? _split_index(dt_parts, " ", 1) : 0)
-            dt_minor = ((length(dt_parts) > 1) ? _split_index(dt_parts, " ", 2) : 0)
+            dt_major = ((((dt_parts != "") && (dt_parts != "no")) && pyconf_is_digit(_split_index(dt_parts, " ", 1))) ? _split_index(dt_parts, " ", 1) : 0)
+            dt_minor = (((length(dt_parts) > 1) && pyconf_is_digit(_split_index(dt_parts, " ", 2))) ? _split_index(dt_parts, " ", 2) : 0)
             if (((dt_major == 10) && (dt_minor <= 2))) {
                 pyconf_error("MACOSX_DEPLOYMENT_TARGET too old (" dt "), only 10.3 or later is supported")
             }
@@ -7931,6 +7939,7 @@ function u_detect_dbm(    _i_db, _n_db, _tmp_split, ac_cv_have_libdb, ac_cv_head
         pyconf_define("HAVE_GDBM_DASH_NDBM_H", 1, 0, "Define to 1 if you have the <gdbm-ndbm.h> header file.")
     }
     if ((((ac_cv_header_gdbm_slash_ndbm_h != "") && (ac_cv_header_gdbm_slash_ndbm_h != "no")) || ((ac_cv_header_gdbm_dash_ndbm_h != "") && (ac_cv_header_gdbm_dash_ndbm_h != "no")))) {
+        r = ""
         pyconf_save_env()
         r = pyconf_search_libs("dbm_open", "gdbm_compat")
         pyconf_restore_env()
@@ -8066,6 +8075,7 @@ function u_check_remaining_libs(    AIX_BUILDDATE, ac_cv_aligned_required) {
 }
 
 function u_check_libatomic(    libatomic_needed) {
+    libatomic_needed = "no"
     pyconf_save_env()
     V["CPPFLAGS"] = _str_strip(V["BASECPPFLAGS"] " -I. -I" pyconf_srcdir "/Include " V["CPPFLAGS"])
     libatomic_needed = ((!pyconf_link_check("whether libatomic is needed by <pyatomic.h>", "\n// pyatomic.h needs uint64_t and Py_ssize_t types\n#include <stdint.h>\n#ifdef HAVE_SYS_TYPES_H\n#  include <sys/types.h>\n#endif\n#if HAVE_SSIZE_T\ntypedef ssize_t Py_ssize_t;\n#elif SIZEOF_VOID_P == SIZEOF_SIZE_T\ntypedef intptr_t Py_ssize_t;\n#else\n#  error \"unable to define Py_ssize_t\"\n#endif\n#include \"pyatomic.h\"\nint main() {\n    uint64_t value;\n    _Py_atomic_store_uint64(&value, 2);\n    if (_Py_atomic_or_uint64(&value, 8) != 2) return 1;\n    if (_Py_atomic_load_uint64(&value) != 10) return 1;\n    uint8_t byte = 0xb8;\n    if (_Py_atomic_or_uint8(&byte, 0x2d) != 0xb8) return 1;\n    if (_Py_atomic_load_uint8(&byte) != 0xbd) return 1;\n    return 0;\n}\n")) ? "yes" : "no")

Tools/configure/pyconf.py

@@ -3548,6 +3548,11 @@ def macro(name: str, args: list | None = None) -> None:
 # The transpiler maps each to a corresponding shell function or built-in.
 
 
+def is_digit(s: str) -> bool:
+    """Return True if *s* is non-empty and all characters are ASCII digits."""
+    return s.isdigit()
+
+
 def fnmatch(string: str, pattern: str) -> bool:
     """Glob-style pattern match (shell: case "$string" in pattern) ...)."""
     return _fnmatch.fnmatch(string, pattern)

Tools/configure/transpiler/lint_transpilable.py

@@ -135,9 +135,10 @@
         "cmd_status",
         "run_program_output",
         "shell",
-        # Pattern matching (pyconf wrapper)
+        # Pattern matching and string predicates (pyconf wrappers)
         "fnmatch",
         "fnmatch_any",
+        "is_digit",
         "sed",
         # Environment save/restore
         "save_env",

Tools/configure/transpiler/pyconf.awk

@@ -1194,6 +1194,10 @@ function pyconf_find_mkdir_p(    result, ver, dirs, n, i, p, prog, progs, cmd) {
 # String / path utilities
 # ---------------------------------------------------------------------------
 
+function pyconf_is_digit(s) {
+        return s ~ /^[0-9]+$/
+}
+
 function pyconf_fnmatch(string, pattern) {
         # Simple glob match using case
         # For exact match patterns, use == comparison