Fix memory leak of iterator in array.array constructor

gleb-pp · gleb-pp · commit c07b8582d22f · 2026-04-13T23:08:49.000+03:00
diff --git a/Modules/arraymodule.c b/Modules/arraymodule.c
@@ -3063,11 +3063,13 @@ array_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
                         PySequence_GetItem(initial, i);
                     if (v == NULL) {
                         Py_DECREF(a);
+                        Py_XDECREF(it);
                         return NULL;
                     }
                     if (setarrayitem(a, i, v) != 0) {
                         Py_DECREF(v);
                         Py_DECREF(a);
+                        Py_XDECREF(it);
                         return NULL;
                     }
                     Py_DECREF(v);

Original file line number	Diff line number	Diff line change
`@@ -3063,11 +3063,13 @@ array_new(PyTypeObject type, PyObject args, PyObject *kwds)`
`3063`	`3063`	`PySequence_GetItem(initial, i);`
`3064`	`3064`	`if (v == NULL) {`
`3065`	`3065`	`Py_DECREF(a);`
	`3066`	`+ Py_XDECREF(it);`
`3066`	`3067`	`return NULL;`
`3067`	`3068`	`}`
`3068`	`3069`	`if (setarrayitem(a, i, v) != 0) {`
`3069`	`3070`	`Py_DECREF(v);`
`3070`	`3071`	`Py_DECREF(a);`
	`3072`	`+ Py_XDECREF(it);`
`3071`	`3073`	`return NULL;`
`3072`	`3074`	`}`
`3073`	`3075`	`Py_DECREF(v);`