fix test

Author: kumaraditya303

Lib/test/test_capi/test_opt.py

@@ -2036,7 +2036,7 @@ def f(n):
         self.assertEqual(uops.count("_BINARY_OP_SUBSCR_DICT_KNOWN_HASH"), 1)
         self.assertEqual(uops.count("_STORE_SUBSCR_DICT_KNOWN_HASH"), 1)
         self.assertEqual(uops.count("_GUARD_NOS_DICT_SUBSCRIPT"), 0)
-        self.assertEqual(uops.count("_GUARD_NOS_DICT_STORE_SUBSCRIPT"), 0)
+        self.assertEqual(uops.count("_GUARD_NOS_DICT_STORE_SUBSCRIPT"), 1)
 
     def test_dict_subclass_subscr_with_override(self):
         class MyDict(dict):

Python/optimizer_bytecodes.c

@@ -1733,29 +1733,43 @@ dummy_func(void) {
 
     op(_GUARD_NOS_DICT_SUBSCRIPT, (nos, unused -- nos, unused)) {
         PyTypeObject *tp = sym_get_type(nos);
+        bool definite = true;
         if (!tp) {
             tp = sym_get_probable_type(nos);
+            definite = false;
         }
         if (tp && tp->tp_as_mapping &&
             tp->tp_as_mapping->mp_subscript == _PyDict_Subscript)
         {
-            PyType_Watch(TYPE_WATCHER_ID, (PyObject *)tp);
-            _Py_BloomFilter_Add(dependencies, tp);
-            ADD_OP(_NOP, 0, 0);
+            if (definite){
+                ADD_OP(_NOP, 0, 0);
+            }
+            else {
+                PyType_Watch(TYPE_WATCHER_ID, (PyObject *)tp);
+                _Py_BloomFilter_Add(dependencies, tp);
+                sym_set_type(nos, tp);
+            }
         }
     }
 
     op(_GUARD_NOS_DICT_STORE_SUBSCRIPT, (unused, nos, unused -- unused, nos, unused)) {
         PyTypeObject *tp = sym_get_type(nos);
+        bool definite = true;
         if (!tp) {
             tp = sym_get_probable_type(nos);
+            definite = false;
         }
         if (tp && tp->tp_as_mapping &&
             tp->tp_as_mapping->mp_ass_subscript == _PyDict_StoreSubscript)
         {
-            PyType_Watch(TYPE_WATCHER_ID, (PyObject *)tp);
-            _Py_BloomFilter_Add(dependencies, tp);
-            ADD_OP(_NOP, 0, 0);
+            if (definite){
+                ADD_OP(_NOP, 0, 0);
+            }
+            else {
+                PyType_Watch(TYPE_WATCHER_ID, (PyObject *)tp);
+                _Py_BloomFilter_Add(dependencies, tp);
+                sym_set_type(nos, tp);
+            }
         }
     }