fix: address comments and add tests

Signed-off-by: yihong0618 <zouzou0208@gmail.com>

Author: yihong0618

Lib/_pyrepl/unix_console.py

@@ -340,10 +340,6 @@ def prepare(self):
             tcsetattr(self.input_fd, termios.TCSADRAIN, raw)
         except termios.error as e:
             if e.args[0] != errno.EIO:
-                # gh-135329
-                # When running under external programs (like strace),
-                # tcsetattr may fail with EIO. We can safely ignore this
-                # and continue with default terminal settings.
                 raise
 
         # In macOS terminal we need to deactivate line wrap via ANSI escape code
@@ -380,8 +376,7 @@ def restore(self):
             tcsetattr(self.input_fd, termios.TCSADRAIN, self.__svtermstate)
         except termios.error as e:
             if e.args[0] != errno.EIO:
-                # gh-135329
-                # When running under external programs (like strace),
+                # gh-135329: when running under external programs (like strace),
                 # tcsetattr may fail with EIO. We can safely ignore this
                 # and continue with default terminal settings.
                 raise
@@ -424,10 +419,6 @@ def get_event(self, block: bool = True) -> Event | None:
                         else:
                             continue
                     elif err.errno == errno.EIO:
-                        # gh-135329
-                        # When running under external programs (like strace),
-                        # os.read may fail with EIO. In this case, we should
-                        # exit gracefully to avoid infinite error loops.
                         import sys
                         sys.exit(errno.EIO)
                     else:

Lib/test/test_pyrepl/test_unix_console.py

@@ -2,11 +2,13 @@
 import os
 import sys
 import unittest
+import errno
+import termios
 from functools import partial
 from test.support import os_helper, force_not_colorized_test_class
 
 from unittest import TestCase
-from unittest.mock import MagicMock, call, patch, ANY
+from unittest.mock import MagicMock, call, patch, ANY, Mock
 
 from .support import handle_all_events, code_to_events
 
@@ -303,3 +305,54 @@ def test_getheightwidth_with_invalid_environ(self, _os_write):
             self.assertIsInstance(console.getheightwidth(), tuple)
             os.environ = []
             self.assertIsInstance(console.getheightwidth(), tuple)
+
+
+class TestUnixConsoleEIOHandling(TestCase):
+
+    @patch('_pyrepl.unix_console.tcsetattr')
+    @patch('_pyrepl.unix_console.tcgetattr')
+    def test_eio_error_handling_in_prepare(self, mock_tcgetattr, mock_tcsetattr):
+        mock_termios = Mock()
+        mock_termios.iflag = 0
+        mock_termios.oflag = 0
+        mock_termios.cflag = 0
+        mock_termios.lflag = 0
+        mock_termios.cc = [0] * 32
+        mock_termios.copy.return_value = mock_termios
+        mock_tcgetattr.return_value = mock_termios
+
+        mock_tcsetattr.side_effect = termios.error(errno.EIO, "Input/output error")
+
+        console = UnixConsole(term="xterm")
+
+        try:
+            console.prepare()
+        except termios.error as e:
+            if e.args[0] == errno.EIO:
+                self.fail("EIO error should have been handled gracefully in prepare()")
+            raise
+
+    @patch('_pyrepl.unix_console.tcsetattr')
+    @patch('_pyrepl.unix_console.tcgetattr')
+    def test_eio_error_handling_in_restore(self, mock_tcgetattr, mock_tcsetattr):
+
+        mock_termios = Mock()
+        mock_termios.iflag = 0
+        mock_termios.oflag = 0
+        mock_termios.cflag = 0
+        mock_termios.lflag = 0
+        mock_termios.cc = [0] * 32
+        mock_termios.copy.return_value = mock_termios
+        mock_tcgetattr.return_value = mock_termios
+
+        console = UnixConsole(term="xterm")
+        console.prepare()
+
+        mock_tcsetattr.side_effect = termios.error(errno.EIO, "Input/output error")
+
+        try:
+            console.restore()
+        except termios.error as e:
+            if e.args[0] == errno.EIO:
+                self.fail("EIO error should have been handled gracefully in restore()")
+            raise