address review

Author: kumaraditya303

Objects/codeobject.c

@@ -1014,9 +1014,12 @@ PyCode_Addr2Line(PyCodeObject *co, int addrq)
     if (addrq < 0) {
         return co->co_firstlineno;
     }
-    if (FT_ATOMIC_LOAD_PTR_ACQUIRE(co->_co_monitoring) &&
-        FT_ATOMIC_LOAD_PTR_ACQUIRE(co->_co_monitoring->lines)) {
-        return _Py_Instrumentation_GetLine(co, addrq/sizeof(_Py_CODEUNIT));
+    _PyCoMonitoringData *data = _Py_atomic_load_ptr_acquire(co->_co_monitoring);
+    if (data) {
+        _PyCoLineInstrumentationData *lines = _Py_atomic_load_ptr_acquire(data->lines);
+        if (lines) {
+            return _Py_Instrumentation_GetLine(co, addrq/sizeof(_Py_CODEUNIT));
+        }
     }
     assert(addrq >= 0 && addrq < _PyCode_NBYTES(co));
     PyCodeAddressRange bounds;

Python/instrumentation.c

@@ -1633,7 +1633,6 @@ initialize_lines(_PyCoLineInstrumentationData *line_data, PyCodeObject *code, in
             set_original_opcode(line_data, handler, original_opcode);
         }
     }
-    FT_ATOMIC_STORE_PTR_RELEASE(code->_co_monitoring->lines, line_data);
 }
 
 static void
@@ -1667,7 +1666,7 @@ allocate_instrumentation_data(PyCodeObject *code)
         monitoring->line_tools = NULL;
         monitoring->per_instruction_opcodes = NULL;
         monitoring->per_instruction_tools = NULL;
-        FT_ATOMIC_STORE_PTR_RELEASE(code->_co_monitoring, monitoring);
+        _Py_atomic_store_ptr_release(code->_co_monitoring, monitoring);
     }
     return 0;
 }
@@ -1738,6 +1737,7 @@ update_instrumentation_data(PyCodeObject *code, PyInterpreterState *interp)
                 return -1;
             }
             initialize_lines(lines, code, bytes_per_entry);
+            _Py_atomic_store_ptr_release(code->_co_monitoring->lines, line_data);
         }
         if (multitools && code->_co_monitoring->line_tools == NULL) {
             code->_co_monitoring->line_tools = PyMem_Malloc(code_len);