fix[imaplib]: call Exception with string instance

[spaceone]

BPO	46943
Nosy	@spaceone, @iritkatriel
PRs	bpo-46943: fix[imaplib]: call Exception with string instance #31722 gh-91099: fix[imaplib]: call Exception with string instance #31823

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-03-07.11:30:04.551>
labels = ['library', '3.9', '3.10', '3.11']
title = 'fix[imaplib]: call Exception with string instance'
updated_at = <Date 2022-03-11.15:48:11.562>
user = 'https://github.com/spaceone'

bugs.python.org fields:

activity = <Date 2022-03-11.15:48:11.562>
actor = 'spaceone'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2022-03-07.11:30:04.551>
creator = 'spaceone'
dependencies = []
files = []
hgrepos = []
issue_num = 46943
keywords = ['patch']
message_count = 7.0
messages = ['414657', '414897', '414903', '414905', '414909', '414911', '414916']
nosy_count = 2.0
nosy_names = ['spaceone', 'iritkatriel']
pr_nums = ['31722', '31823']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue46943'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[spaceone]

imaplib raises an Exception with a bytes instance once (in login()) - all other places str instances are raised.

Adjust the behavior of login() similar to authenticate() where self.error is called with a str instance.

Especially for Python3 with strict bytes mode (-bb) this is helpful and prevents:

    Traceback (most recent call last):
      in "<stdin>"
        self.login(email, password)
      File "/usr/lib/python3.7/imaplib.py", line 598, in login
        raise self.error(dat[-1])
    imaplib.error: <exception str() failed>
    
    During handling of the above exception, another exception occurred:
    Traceback (most recent call last):
      in "<stdin>"
        str(exc)
    BytesWarning: str() on a bytes instance