gh-117026: fix wrong sentence in SimpleHTTPRequestHandler #117027
Merged
Conversation
…xt files The code does not differentiate between text and binary files so the sentence should be removed from the doc. See python#117026
|
All commit authors signed the Contributor License Agreement. |
Contributor
davidlowryduda
left a comment
davidlowryduda
left a comment
There was a problem hiding this comment.
This seems good. But something that confuses me is that it looks like the line of code in server.py has never changed, so it's not like this something that changed from python2 to python3.
This feels like Chesterson's fence.
serhiy-storchaka
approved these changes
May 16, 2025
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
Thank you for your contribution @SalehDehqanpour.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @SalehDehqanpour for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2025
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531). (cherry picked from commit ea2d707) Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 16, 2025
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531). (cherry picked from commit ea2d707) Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
|
GH-134107 is a backport of this pull request to the 3.14 branch. |
|
GH-134108 is a backport of this pull request to the 3.13 branch. |
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
… docs (pythonGH-117027) The code was changed in 0f7cddc (bpo-839496/pythongh-39531).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code does not differentiate between text and binary files so the sentence should be removed from the doc. See #117026
📚 Documentation preview 📚: https://cpython-previews--117027.org.readthedocs.build/