Skip to content

gh-126464 Fix jit build on aarch64 macos#126494

Merged
brandtbucher merged 5 commits into
python:mainfrom
alonme:fix-mac-jit-ci
Nov 7, 2024
Merged

gh-126464 Fix jit build on aarch64 macos#126494
brandtbucher merged 5 commits into
python:mainfrom
alonme:fix-mac-jit-ci

Conversation

@alonme

@alonme alonme commented Nov 6, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Updating the Command Line Tools for Xcode version in hope it will solve jit build failure on macos

@alonme alonme requested a review from brandtbucher as a code owner November 6, 2024 12:53
@ghost

ghost commented Nov 6, 2024 •
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Nov 6, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Nov 6, 2024
Closed
@bedevere-app

bedevere-app Bot commented Nov 6, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

ZeroIntensity
ZeroIntensity reviewed Nov 6, 2024
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that gh-126465 fixed the JIT failures, and we're waiting on an upstream fix. Do we need this?

@ZeroIntensity ZeroIntensity added infra CI, GitHub Actions, buildbots, Dependabot, etc. topic-JIT labels Nov 6, 2024
@brandtbucher

brandtbucher commented Nov 6, 2024

Copy link
Copy Markdown
Member

This doesn't seem to fix the issue.

@alonme alonme changed the title gh-126464 Update xcode command line tools for jit build on macos gh-126464 Fix jit build on aarch64 macos Nov 7, 2024
savannahostrowski
savannahostrowski approved these changes Nov 7, 2024
View reviewed changes

@savannahostrowski savannahostrowski left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Awesome, so this probably boils down to a version/path problem...

As a sidenote, I also saw actions/runner-images#10917, which may fix this issue as it removes the newest version of xcode. However, it doesn't hurt to explicitly state SDKROOT anyway. What's interesting is that when I was building LLVM from source awhile ago, I also had to specify SDKROOT for newer LLVM to find headers.

Thanks so much!

brandtbucher
brandtbucher approved these changes Nov 7, 2024
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One suggestion:

Comment thread .github/workflows/jit.yml Outdated
SDKROOT="$(xcrun --show-sdk-path)" \
./configure --enable-experimental-jit ${{ matrix.debug && '--with-pydebug' || '--enable-optimizations --with-lto' }}
make all --jobs 4
SDKROOT="$(xcrun --show-sdk-path)" make all --jobs 4

@brandtbucher brandtbucher Nov 7, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're doing this on line 134 too, maybe just remove both and put export SDKROOT="$(xcrun --show-sdk-path)" before the ./configure step?

@alonme alonme Nov 7, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Done

@brandtbucher brandtbucher self-assigned this Nov 7, 2024
@brandtbucher brandtbucher merged commit 09d6f5d into python:main Nov 7, 2024
@Eclips4 Eclips4 mentioned this pull request Dec 1, 2024
Closed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@alonme @picnixz
pythonGH-126464 Fix JIT CI on aarch64-apple-darwin (pythonGH-126494)
12b87c6
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@alonme @ebonnal
pythonGH-126464 Fix JIT CI on aarch64-apple-darwin (pythonGH-126494)
05a2ccb
@vstinner vstinner mentioned this pull request Mar 27, 2026
Merged
@hugovk hugovk added the needs backport to 3.13 bugs and security fixes label Mar 27, 2026
@miss-islington-app

miss-islington-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

Thanks @alonme for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Mar 27, 2026

Copy link
Copy Markdown

Sorry, @alonme and @brandtbucher, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 09d6f5dc7824c74672add512619e978844ff8051 3.13

hugovk pushed a commit to hugovk/cpython that referenced this pull request Mar 27, 2026
@alonme @hugovk
[3.13] pythonGH-126464 Fix JIT CI on aarch64-apple-darwin (pythonGH-1…
1721a06 
…26494)

(cherry picked from commit 09d6f5d)

Co-authored-by: alm <alonme@users.noreply.github.com>
hugovk added a commit to hugovk/cpython that referenced this pull request Mar 27, 2026
@hugovk
Include export fix from pythongh-126494
92fade7
@hugovk

hugovk commented Mar 27, 2026

Copy link
Copy Markdown
Member

Backport added to #146414 instead.

@hugovk hugovk removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@savannahostrowski savannahostrowski savannahostrowski approved these changes

@brandtbucher brandtbucher brandtbucher approved these changes

Assignees

@brandtbucher brandtbucher

Labels

infra CI, GitHub Actions, buildbots, Dependabot, etc. skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alonme @brandtbucher @hugovk @savannahostrowski @ZeroIntensity