-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
gh-134567: Exposes log format to users in unittest.TestCase.assertLogs #134570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 6 commits
f8ff127
59e8f3f
821f828
d96dca3
6009858
7881c64
ff3e9af
ec353d2
766d6a2
7ee8aba
10aa529
ca72d91
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -274,6 +274,14 @@ typing | |
| (Contributed by Bénédikt Tran in :gh:`133823`.) | ||
|
|
||
|
|
||
| unittest | ||
| -------- | ||
| * Expose log formatter to users in TestCase.assertLogs. | ||
garry-cairns marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| :func:`unittest.TestCase.assertLogs` will now accept a formatter | ||
| argument so your assertions can match a custom format where you are using one. | ||
| (Contributed by Garry Cairns in :gh:`134567`.) | ||
|
Comment on lines
+294
to
+300
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @garry-cairns This is under the "Removed" section: https://docs.python.org/3.15/whatsnew/3.15.html#removed Please could you move it to the "Improved modules" section above? https://docs.python.org/3.15/whatsnew/3.15.html#improved-modules (We could also remove the first sentence "Lets users specify formatter in TestCase.assertLogs", as the next sentence essentially repeats it.)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apologies for the noise on this. I've created #136630 to resolve this. |
||
|
|
||
|
|
||
| wave | ||
| ---- | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Expose log formatter to users in TestCase.assertLogs. | ||
| :func:`unittest.TestCase.assertLogs` will now accept a formatter argument so your assertions can match a custom format where you are using one. |
Uh oh!
There was an error while loading. Please reload this page.