gh-135615: Rephrase HTTP status codes overview#135625
gh-135615: Rephrase HTTP status codes overview#135625sharktide wants to merge 4 commits intopython:mainfrom
Conversation
AA-Turner
left a comment
There was a problem hiding this comment.
Better to note that 418 is an exception than to remove this useful reference.
A
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
|
Gentle ping |
AA-Turner
left a comment
There was a problem hiding this comment.
Thank you for the reminder.
Revisiting the substance of this change, I'm on the fence. The website lists 418 as "418 (Unused) [RFC9110, Section 15.5.19]". This contrasts to other ranges, which are listed as "Unassigned". The RFC goes on to note that "the 418 status code is reserved in the IANA HTTP Status Code Registry".
If we do go ahead with this change, I've suggested a rewording that I hope clarifies matters.
A
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
Oops typo in commit msg |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @AA-Turner: please review the changes made to this pull request. |
|
Gentle ping |
|
@AA-Turner should I close ? It’s been ~7mo |
|
This PR is stale because it has been open for 30 days with no activity. |
The HTTP module supports status codes that are unregistered/unofficial. Take http status code
418: I'm a teapotDue to the save418 movement (https://save418.com/), python decided to preserve http code 418 in its codebase, but the documentation contradicts itself.In the documentation, right above the table of status codes supported by the http library we have this:
This is factually incorrect, because code 418, (among others) is not official, and this PR lists 418 as an exception
Fix #135615
📚 Documentation preview 📚: https://cpython-previews--135625.org.readthedocs.build/