gh-54732: Make argparse error caused by empty rows in option files explicit#136795
Merged
AA-Turner merged 6 commits intopython:mainfrom Jul 19, 2025
Merged
gh-54732: Make argparse error caused by empty rows in option files explicit#136795AA-Turner merged 6 commits intopython:mainfrom
AA-Turner merged 6 commits intopython:mainfrom
Conversation
Member
|
Please use the format you have in the issue description for the title, it allows our automation to link it. You also need to sign the CLA. |
d2dd1e9 to
1cfa51b
Compare
Member
|
Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide. |
Namely the use of code markup. Also I fixed a trailing whitespace.
Change two of the phrasings to make it more clear. Use straight quotes.
AA-Turner
reviewed
Jul 19, 2025
AA-Turner
approved these changes
Jul 19, 2025
|
Thanks @jdunter for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2025
…les explicit (pythonGH-136795) (cherry picked from commit 8ffc3ef) Co-authored-by: jdunter <2ve@mailbox.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 19, 2025
…les explicit (pythonGH-136795) (cherry picked from commit 8ffc3ef) Co-authored-by: jdunter <2ve@mailbox.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
|
GH-136818 is a backport of this pull request to the 3.14 branch. |
|
GH-136819 is a backport of this pull request to the 3.13 branch. |
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…les explicit (python#136795) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…les explicit (python#136795) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…tion files explicit (pythonGH-136795) (python#136818) pythongh-54732: Make argparse error caused by empty rows in option files explicit (pythonGH-136795) (cherry picked from commit 8ffc3ef) Co-authored-by: jdunter <2ve@mailbox.org> Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Note to the documentation, that addresses the error caused by an empty row in an argparse option file.
📚 Documentation preview 📚: https://cpython-previews--136795.org.readthedocs.build/