gh-136787: raise consistent ValueError for bad hashes#136802
Merged
picnixz merged 6 commits intopython:mainfrom Jul 20, 2025
Merged
gh-136787: raise consistent ValueError for bad hashes#136802picnixz merged 6 commits intopython:mainfrom
picnixz merged 6 commits intopython:mainfrom
Conversation
Member
Author
|
For now, I'm adding a skip news just to run the builbots. I'll come back tomorrow. |
Member
Author
|
!buildbot FIPS only |
This comment was marked as resolved.
This comment was marked as resolved.
picnixz
force-pushed
the
feat/hashlib/same-error-messages-136787
branch
from
d2fa695 to
db6f4db
Compare
Member
Author
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit db6f4db 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136802%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
gpshead
reviewed
Jul 19, 2025
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
overall good, mostly little details in comments or naming
picnixz
commented
Jul 19, 2025
picnixz
commented
Jul 19, 2025
picnixz
commented
Jul 19, 2025
picnixz
commented
Jul 19, 2025
picnixz
commented
Jul 19, 2025
picnixz
commented
Jul 19, 2025
picnixz
commented
Jul 19, 2025
Member
Author
|
I really should avoid using the web editor. I'll make the changes tomorrow. |
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueErrorexception messages when a hash digest is not available #136787