gh-77589: Add unix domain socket for Windows#137420
Conversation
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Instead of skipping some tests, would not be worth to test a Windows specific behavior?
Some tests can currently be skipped on Windows, but they may work after adding support of AF_UNIX. Please check all currently skipped tests for socket and multiprocessing.
|
It seems that the previous attempt did have more changes in the |
The previous attempt modified the The change in |
Hi, I updated the test to test Windows-specific behaviors, and checked current tests which can be enabled after we added AF_UNIX, but not finding one. Most tests are skipped by some stuff like 'skipUnless(hasattr(socket, "AF_UNIX))'. There is a noticeable remark for the reviewer: The |
|
This PR is stale because it has been open for 30 days with no activity. |
|
What's the status of this PR? It seems ready for merge, are there any standing issues? |
Didn't add
asynciosupport in this PR to avoid too many code changes and keep the review process simpler.