Skip to content

GH-142305: JIT: Deduplicating GOT symbols in the trace#142316

Merged
diegorusso merged 3 commits into
python:mainfrom
diegorusso:got-symbols
Dec 10, 2025
Merged

GH-142305: JIT: Deduplicating GOT symbols in the trace#142316
diegorusso merged 3 commits into
python:mainfrom
diegorusso:got-symbols

Conversation

@diegorusso

@diegorusso diegorusso commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

@diegorusso diegorusso changed the title GH-142305: JIT: Deduplicating GOT symbols in the trace gh-142305: JIT: Deduplicating GOT symbols in the trace Dec 8, 2025
@diegorusso diegorusso changed the title gh-142305: JIT: Deduplicating GOT symbols in the trace GH-142305: JIT: Deduplicating GOT symbols in the trace Dec 8, 2025

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about the design choice!

Meta comment: man, I feel like GitHub has done this to me twice now where it's posted stale comments and/or eaten comments I've written during review...

@bedevere-app

bedevere-app Bot commented Dec 8, 2025

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Comment thread Python/jit.c
Comment thread Python/jit.c
@diegorusso diegorusso merged commit 4629567 into python:main Dec 10, 2025
78 of 80 checks passed
@diegorusso diegorusso deleted the got-symbols branch December 10, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants