gh-142489: Increase ssl_handshake_timeout in asyncio tests#142523
Conversation
Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.
|
Thanks. I'll check if this makes a difference in ELN/EPEL builds. |
|
I submitted 5 builds each for Python 3.15.0a2 (on ELN), 3.14.2 (on ELN), and 3.13.11 (on EPEL 10.1), with this PR backported as well as 5 builds each without it. Statistically, this improves things. Without this patch, 7 out of the total 15 builds failed with With this patch applied, only one failed with What worries me a bit is that the exception still mentions 67.5 or 60.0 seconds. As if the SSL handshake had its own timeout set? |
Hum. There were remaining open_connection() calls with the default timeout of
Yes, it's
|
|
Trying again. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…honGH-142523) Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs. And add the HANDSHAKE_TIMEOUT constant. (cherry picked from commit dc3ece2) Co-authored-by: Victor Stinner <vstinner@python.org>
…honGH-142523) Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs. And add the HANDSHAKE_TIMEOUT constant. (cherry picked from commit dc3ece2) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-142545 is a backport of this pull request to the 3.14 branch. |
|
GH-142546 is a backport of this pull request to the 3.13 branch. |
|
Merged, thanks for testing @hroncok. I hope that this change will make timeout errors less likely on very slow CIs. |
30 builds (10 for each Python version) and no timeout. Seems to work properly now, thanks. |
Replace SHORT_TIMEOUT with LONG_TIMEOUT for very slow CIs.