gh-145200: Fix EVP_MAC_CTX leak in hashlib HMAC on init failure#145201
Merged
gpshead merged 5 commits intopython:mainfrom Apr 11, 2026
Merged
gh-145200: Fix EVP_MAC_CTX leak in hashlib HMAC on init failure#145201gpshead merged 5 commits intopython:mainfrom
gpshead merged 5 commits intopython:mainfrom
Conversation
picnixz
reviewed
Feb 25, 2026
picnixz
reviewed
Feb 25, 2026
…_4PAtcI.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Feb 25, 2026
…_4PAtcI.rst Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Member
|
I'm going to run the refleak bots just in case so don't commit anything until the tests are done, TiA! |
picnixz
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit b175558 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145201%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Contributor
Author
|
CC: @picnixz |
Member
|
Tests are failing. |
gpshead
approved these changes
Apr 11, 2026
|
Sorry, @raminfp and @gpshead, I could not cleanly backport this to |
Member
|
Yes, it's a 3.15-only change (it's when I used OpenSSL 3 HMAC EVP API) |
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…pythonGH-145201) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Free the
EVP_MAC_CTX(orHMAC_CTX) whenEVP_MAC_init()(orHMAC_Init_ex()) fails inhashlib_HMAC_CTX_new_from_digestmod(), preventing a memory leak on every failed call._hashlib:EVP_MAC_CTXleak inhashlib_HMAC_CTX_new_from_digestmod()whenEVP_MAC_init()fails #145200