gh-37883: Safely skip test_resource file size tests when limits are strict by Shrey-N · Pull Request #145579 · python/cpython

Shrey-N · 2026-03-06T08:15:54Z

This fixes the Standing issue #37883 where test_resource would fail on systems with file size limitations

Previous attempts (like #140872) tried to introduce massive refactoring and helper classes. Based on reviewer feedback I read there, I have tried a minimal fix

It checks if the system's hard limit is large enough, and if the OS actually allows the limit to be modified. If not, it uses self.skipTest with an informative message rather than failing with an unhandled OSError or ValueError.
It replaces the fragile dual try...finally resource restoration blocks with self.addCleanup(), guaranteeing that limits are reset even during a test assertion failure.

Fixes #37883

Issue: test_resource fails when file size is limited #37883

… are strict

python-cla-bot · 2026-03-06T08:16:02Z

All commit authors signed the Contributor License Agreement.

Shrey-N · 2026-03-06T12:08:02Z

I have added a news entry, though I am not sure if it's necessary or for this fix, Please let me know if I should remove it :)

encukou

This looks good!

We don't need a NEWS entry for a test-only change.

Lib/test/test_resource.py

Shrey-N · 2026-03-10T14:29:00Z

@encukou Alrighty thank you, I was confused as to add it or not so thank you for clearing that up :), also I will incorporate your reviews in a second :)

Remove unnecessary blank line

encukou · 2026-03-13T13:21:13Z

I think you can roll back the last 4 commits.

In d21ceb8, the removed comment says:

            # Close will attempt to flush the byte we wrote
            # Restore limit first to avoid getting a spurious error

That should stay, i.e. the try/finally should go inside the with, not the other way around.

Shrey-N · 2026-03-13T15:24:57Z

Alright will look into it asap

Shrey-N · 2026-03-15T15:40:30Z

@encukou I believe everything should work now :) Sorry for the late reply

Removed unused import of the 'time' module.

…Zq.rst

Shrey-N · 2026-03-29T06:47:56Z

@encukou Hi, I believe I fixed the tests that were failing from my side in this PR, I am pretty sure this time, it's not my fault :) lmk if I am to make any other changes :)

Lib/test/test_resource.py

bedevere-bot · 2026-04-07T14:01:40Z

🤖 New build scheduled with the buildbot fleet by @encukou for commit 4564e1f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145579%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Shrey-N · 2026-04-07T15:25:26Z

Accepted all suggestions, thanks!

encukou · 2026-04-08T14:06:10Z

Thank you!

miss-islington-app · 2026-04-08T14:06:21Z

Thanks @Shrey-N for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2026-04-08T14:06:21Z

Thanks @Shrey-N for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2026-04-08T14:06:23Z

Sorry, @Shrey-N and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 461125aaa331fe2b39452c852ee26d0161b2436e 3.13

miss-islington-app · 2026-04-08T14:06:29Z

Sorry, @Shrey-N and @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 461125aaa331fe2b39452c852ee26d0161b2436e 3.14

encukou · 2026-04-08T14:08:24Z

We usually backport test fixes to earlier versions, but mostly to avoid conflicts in future fixes. Since there are conflicts already, I'll skip backporting.

If you need the fix in an earlier version, feel free to open a backport PR.

pythongh-37883: Safely skip test_resource file size tests when limits…

3cae226

… are strict

bedevere-app bot added the tests Tests in the Lib/test dir label Mar 6, 2026

bedevere-app bot added the awaiting review label Mar 6, 2026

bedevere-app bot mentioned this pull request Mar 6, 2026

test_resource fails when file size is limited #37883

Closed

Shrey-N force-pushed the fixy-branch branch from 41f9750 to 3cae226 Compare March 6, 2026 08:18

blurb-it bot and others added 2 commits March 6, 2026 09:43

📜🤖 Added by blurb_it.

f217fb1

Update News Entry

ef28dbc

Update 2026-03-06-09-43-49.gh-issue-37883.I-3oZq.rst

f74f58e

encukou reviewed Mar 10, 2026

View reviewed changes

Lib/test/test_resource.py Outdated Show resolved Hide resolved

Lib/test/test_resource.py Outdated Show resolved Hide resolved

encukou added the skip news label Mar 10, 2026

Shrey-N added 5 commits March 10, 2026 20:22

Refactor test_resource.py on the advice

d21ceb8

fix lint error

65b0b88

Remove unnecessary blank line

Update test_resource.py

1600c31

Fix formatting in test_resource.py

7fb6b72

Update test_resource.py

29255c2

Update test_resource.py

3dc4653

Shrey-N added 6 commits March 15, 2026 20:41

Fix indentation in test_resource.py

de3c792

Remove unused 'time' import from test_resource.py

61822dd

Removed unused import of the 'time' module.

Delete Misc/NEWS.d/next/Tests/2026-03-06-09-43-49.gh-issue-37883.I-3o…

3b02180

…Zq.rst

Update test_resource.py

befd67a

Update test_resource.py

16acaa4

Refactor resource limit tests for clarity and cleanup

4f7a349

Merge branch 'main' into fixy-branch

4564e1f

encukou reviewed Apr 7, 2026

View reviewed changes

Lib/test/test_resource.py Show resolved Hide resolved

Lib/test/test_resource.py Show resolved Hide resolved

Lib/test/test_resource.py Outdated Show resolved Hide resolved

encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 7, 2026

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 7, 2026

Shrey-N and others added 3 commits April 7, 2026 20:54

Update based on suggestion

1808a8a

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Update Lib/test/test_resource.py based on suggestion

6faed32

Co-authored-by: Petr Viktorin <encukou@gmail.com>

Update Lib/test/test_resource.py

58fb908

Co-authored-by: Petr Viktorin <encukou@gmail.com>

encukou merged commit 461125a into python:main Apr 8, 2026
87 of 89 checks passed

bedevere-app bot removed the awaiting review label Apr 8, 2026

encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 8, 2026

miss-islington-app bot assigned encukou Apr 8, 2026

encukou removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 8, 2026

Uh oh!

Conversation

Shrey-N commented Mar 6, 2026 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

python-cla-bot bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shrey-N commented Mar 6, 2026

Uh oh!

encukou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Shrey-N commented Mar 10, 2026

Uh oh!

encukou commented Mar 13, 2026

Uh oh!

Shrey-N commented Mar 13, 2026

Uh oh!

Shrey-N commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shrey-N commented Mar 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Apr 7, 2026

Uh oh!

Shrey-N commented Apr 7, 2026

Uh oh!

Uh oh!

encukou commented Apr 8, 2026

Uh oh!

miss-islington-app bot commented Apr 8, 2026

Uh oh!

miss-islington-app bot commented Apr 8, 2026

Uh oh!

miss-islington-app bot commented Apr 8, 2026

Uh oh!

miss-islington-app bot commented Apr 8, 2026

Uh oh!

encukou commented Apr 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Shrey-N commented Mar 6, 2026 •

edited by bedevere-app bot

Loading

python-cla-bot bot commented Mar 6, 2026 •

edited

Loading

Shrey-N commented Mar 15, 2026 •

edited

Loading