Skip to content

gh-146054: Limit the growth of encodings.search_function cache #146055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 5 commits into from
Mar 17, 2026
+18 −0
Merged

gh-146054: Limit the growth of encodings.search_function cache #146055

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a6c942c
Limit the growth of `encodings.search_function` cache
StanFromIreland Mar 17, 2026
ed48ab8
Add OSS Fuzz issue
StanFromIreland Mar 17, 2026
d57d397
LRU cache
StanFromIreland Mar 17, 2026
ef28517
Accidentally removed comment.
StanFromIreland Mar 17, 2026
ecc71c4
Merge branch 'main' into encodings-cache
StanFromIreland Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Lib/encodings/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,9 @@ def search_function(encoding):
mod = None

if mod is None:
if len(_cache) < _MAXCACHE:
_cache[encoding] = None
if len(_cache) >= _MAXCACHE:
_cache.clear()
Comment thread
picnixz marked this conversation as resolved.
_cache[encoding] = None
return None

# Now ask the module for the registry entry
Expand All @@ -133,6 +134,8 @@ def search_function(encoding):
entry = codecs.CodecInfo(*entry)

# Cache the codec registry entry
if len(_cache) >= _MAXCACHE:
_cache.clear()
_cache[encoding] = entry

# Register its aliases (without overwriting previously registered
Expand Down
Loading