GH-146128: Remove the buggy AArch64 "33rx" relocation#146263
Open
brandtbucher wants to merge 2 commits intopython:mainfrom
Open
GH-146128: Remove the buggy AArch64 "33rx" relocation#146263brandtbucher wants to merge 2 commits intopython:mainfrom
brandtbucher wants to merge 2 commits intopython:mainfrom
Conversation
brandtbucher
requested review from
diegorusso and
savannahostrowski
as code owners
brandtbucher
added
interpreter-core
Contributor
|
Did you have a chance to measure performance impact? |
Member
Author
|
I'm not too concerned with performance impact because it's a correctness issue. But we can run it if we're curious. |
Member
Author
|
But even if it's, say, 1% slower, the right thing to do is rip this out from existing branches and do something better in the textual assembly pass in 3.15. |
Member
|
I'd like to handle the relocations properly, rather than just remove it. I've made the issue a blocker. If we can't do it properly before the release, we can merge this. |
Member
|
Ready to merge for tomorrow's releases? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch_aarch64_33rxrelocation isn't safe #146128