Skip to content

GH-126910: reserve FP on AArch64 when generating JIT stencils #146520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 4 commits into from
Mar 27, 2026
+4 −1
Merged

GH-126910: reserve FP on AArch64 when generating JIT stencils #146520

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b86c02
GH-126910: reserve FP on AArch64 when generating JIT stencils
diegorusso Mar 26, 2026
805e23e
Let's do it just for Linux AArch64 for now
diegorusso Mar 27, 2026
926c1c2
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 27, 2026
514e449
Add patch note for frame pointers in JIT code
diegorusso Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Tools/jit/_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ async def _compile(
# We *may* be able to re-enable this, process it, and JIT it for a
# nicer debugging experience... but that needs a lot more research:
"-fno-asynchronous-unwind-tables",
"-fno-unwind-tables",
# Don't call built-in functions that we can't find or patch:
"-fno-builtin",
# Don't call stack-smashing canaries that we can't find or patch:
Expand Down Expand Up @@ -580,20 +581,24 @@ def get_target(host: str) -> _COFF32 | _COFF64 | _ELF | _MachO:
host = "aarch64-apple-darwin"
condition = "defined(__aarch64__) && defined(__APPLE__)"
optimizer = _optimizers.OptimizerAArch64
target = _MachO(host, condition, optimizer=optimizer)
target = _MachO(host, condition, optimizer=optimizer, frame_pointers=True)
elif re.fullmatch(r"aarch64-pc-windows-msvc", host):
host = "aarch64-pc-windows-msvc"
condition = "defined(_M_ARM64)"
args = ["-fms-runtime-lib=dll"]
optimizer = _optimizers.OptimizerAArch64
target = _COFF64(host, condition, args=args, optimizer=optimizer)
target = _COFF64(
host, condition, args=args, optimizer=optimizer, frame_pointers=True
)
elif re.fullmatch(r"aarch64-.*-linux-gnu", host):
host = "aarch64-unknown-linux-gnu"
condition = "defined(__aarch64__) && defined(__linux__)"
# -mno-outline-atomics: Keep intrinsics from being emitted.
args = ["-fpic", "-mno-outline-atomics", "-fno-plt"]
optimizer = _optimizers.OptimizerAArch64
target = _ELF(host, condition, args=args, optimizer=optimizer)
target = _ELF(
host, condition, args=args, optimizer=optimizer, frame_pointers=True
)
elif re.fullmatch(r"i686-pc-windows-msvc", host):
host = "i686-pc-windows-msvc"
condition = "defined(_M_IX86)"
Expand Down
Loading