Skip to content

gh-146656: properly raise NotImplementedError instead of NotImplemented in test_discover #146661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FFY00 merged 3 commits into from
Apr 1, 2026
Merged

gh-146656: properly raise NotImplementedError instead of NotImplemented in test_discover #146661

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af6f7a6
Change NotImplemented to NotImplementedError
Locked-chess-official Mar 31, 2026
ac14dd9
Update Lib/test/test_importlib/test_discover.py
Locked-chess-official Apr 1, 2026
ae1b8b9
Apply suggestion from @vstinner
FFY00 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_importlib/test_discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ def __init__(self, discover=[]):
self._discovered_values = discover

def find_spec(self, fullname, path=None, target=None):
raise NotImplemented
raise NotImplementedError()

def discover(self, parent=None):
yield from self._discovered_values
Expand Down
Loading