Skip to content

gh-148119: Refactor get_type_attr_as_size to improve error handling in structseq.c #148120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
Apr 6, 2026
+5 −1
Merged

gh-148119: Refactor get_type_attr_as_size to improve error handling in structseq.c #148120

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c08c7b1
gh-148119: Refactor `get_type_attr_as_size` to improve error handling…
Wulian233 Apr 5, 2026
abcab36
update
Wulian233 Apr 5, 2026
3094d66
update
Wulian233 Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Objects/structseq.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,23 @@ static Py_ssize_t
get_type_attr_as_size(PyTypeObject *tp, PyObject *name)
{
PyObject *v = PyDict_GetItemWithError(_PyType_GetDict(tp), name);
if (v == NULL && !PyErr_Occurred()) {

if (v == NULL) {
if (PyErr_Occurred()) {
return -1;
}
PyErr_Format(PyExc_TypeError,
"Missed attribute '%U' of type %s",
name, tp->tp_name);
return -1;
}
return PyLong_AsSsize_t(v);

Py_ssize_t result = PyLong_AsSsize_t(v);
if (result == -1 && PyErr_Occurred()) {
return -1;
}

return result;
}

#define VISIBLE_SIZE(op) Py_SIZE(op)
Expand Down
Loading