gh-148157: Check for _PyPegen_add_type_comment_to_arg fail in _PyPegen_name_default_pair#148158
Merged
StanFromIreland merged 2 commits intopython:mainfrom Apr 6, 2026
Merged
Conversation
StanFromIreland
requested review from
JelleZijlstra,
lysnikolaou and
pablogsal
as code owners
pablogsal
approved these changes
Apr 6, 2026
pablogsal
added
awaiting core review
needs backport to 3.13
|
Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 6, 2026
… `_PyPegen_name_default_pair` (pythonGH-148158) (cherry picked from commit 1795fccfbc7ccb89ead5c529b2f55f54622d1314) Co-authored-by: Stan Ulbrych <stan@python.org>
|
GH-148162 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 6, 2026
… `_PyPegen_name_default_pair` (pythonGH-148158) (cherry picked from commit 1795fccfbc7ccb89ead5c529b2f55f54622d1314) Co-authored-by: Stan Ulbrych <stan@python.org>
|
GH-148163 is a backport of this pull request to the 3.13 branch. |
Member
Author
|
Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_PyPegen_add_type_comment_to_argcan fail in_PyPegen_name_default_pair#148157