gh-148091: asyncio : clarify Future.cancel(msg) behaviour#148248
gh-148091: asyncio : clarify Future.cancel(msg) behaviour#148248manoj-k-m wants to merge 3 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
1 similar comment
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@bedevere-bot skip news |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Please update the asyncio documentation, not the docstring. We don't generate the documentation from docstrings.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
The
msgparameter of Future.cancel() is currently undocumented.This change clarifies that the optional
msgargument is passed as the argument to asyncio.CancelledError raised whena cancelled Future is awaited, and that it can be of any object.
Fixes #148091
msgparameter forasyncio.futures.Future.cancelis used #148091skip news