Skip to content

gh-148398: add type watcher in _CHECK_ATTR_CLASS #148399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 4 commits into from
Apr 12, 2026
+9 −0
Merged

gh-148398: add type watcher in _CHECK_ATTR_CLASS #148399

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca70b69
gh-148398: add type watcher in `_CHECK_ATTR_CLASS`
NekoAsakura Apr 11, 2026
6ee2de7
gh-148398: add NEWS
NekoAsakura Apr 11, 2026
8cb0b3c
Merge branch 'main' into gh-148398/add-type-watcher
NekoAsakura Apr 11, 2026
c1eeb13
gh-148398: add type watcher in `_CHECK_ATTR_CLASS`
NekoAsakura Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2026-04-11-15-12-53.gh-issue-148398.g62jCA.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug in the JIT optimizer where class attribute loads were not invalidated after type mutation.
2 changes: 2 additions & 0 deletions Python/optimizer_bytecodes.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,8 @@ dummy_func(void) {
}
else {
sym_set_const(owner, type);
PyType_Watch(TYPE_WATCHER_ID, type);
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 Apr 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to add type watcher if type is immutable.

Copy link
Copy Markdown
Member

@Fidget-Spinner Fidget-Spinner Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref #148383

_Py_BloomFilter_Add(dependencies, type);
}
}
}
Expand Down
2 changes: 2 additions & 0 deletions Python/optimizer_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading