-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
gh-109653: Improve import performance of tkinter library with lazy imports
#148409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sharktide
wants to merge
15
commits into
python:main
Choose a base branch
from
sharktide:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−15
Open
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f0e2f9b
Lazy import modules in tkinter __init__
sharktide 4bcb491
Add _get_magic_re and _get_space_re functions.
sharktide 995d6a1
Update usage in _stringify
sharktide 44567a4
Add docstring to new functions
sharktide 0dfab78
Format
sharktide ce94f9e
Add NEWS entry
sharktide 01000ea
Move lazy import re down in the file
sharktide 1da6e7b
Reorder imports for clarity
sharktide f0bd1eb
Stop lazy imported modules from appearing in __all__
sharktide e9803f4
Remove lazy import from sys and types
sharktide 8350043
Improved docstrings for new functions
sharktide 2558665
Add TestTkImportTime test class in MISC
sharktide 5674a95
Lazy import os and traceback
sharktide b78daf7
Fix import in lazy import test
sharktide e269325
Update NEWS entry
sharktide File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2026-04-11-18-49-40.gh-issue-109653.VXU-w8.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Reduce the import time of :mod:`tkinter` with lazy imports. Patch by Rihaan | ||
| Meher. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.