Skip to content

gh-148259: make list.remove atomic for non-trivial __eq__ comparison #148440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KowalskiThomas wants to merge 4 commits into
base: main
Choose a base branch
from
+48 −24
Draft

gh-148259: make list.remove atomic for non-trivial __eq__ comparison #148440

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4f4d57
bug: prevent race condition in list.remove
KowalskiThomas Apr 8, 2026
6b97b07
test: fix test_xml_etree
KowalskiThomas Apr 13, 2026
c30ea14
news: add entry
KowalskiThomas Apr 13, 2026
648c3f6
test: update test_xml_etree
KowalskiThomas Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Objects/listobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3390,6 +3390,11 @@ list_remove_impl(PyListObject *self, PyObject *value)
int cmp = PyObject_RichCompareBool(obj, value, Py_EQ);
Py_DECREF(obj);
if (cmp > 0) {
if (i >= Py_SIZE(self) || self->ob_item[i] != obj) {
PyErr_SetString(PyExc_RuntimeError,
"list mutated during remove");
return NULL;
}
if (list_ass_slice_lock_held(self, i, i+1, NULL) == 0)
Py_RETURN_NONE;
return NULL;
Expand Down
Loading