-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
gh-148690: Build Windows freethreaded binaries into separate directory and include python3t.dll on GIL-enabled #149218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 19 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
5db5a47
Link against python3t.lib
encukou 1153d48
Add ABI3T_COMPAT_DLLNAME
encukou fda3900
Build abi3t-compat\python3t.dll
encukou 96676cf
Add abi3tcompat to MSI installer
encukou 32083dd
minimal fix for build errors on Petr's PR
ngoldbaum e25d7ff
Merge in the main branch
encukou eb61469
Build python3.dll & python3t.dll separately, with fixed names
encukou 92ae703
Don't use !(bindpath.build)
encukou 3dc7bc1
Apply suggestions from code review
encukou b64ad2c
Look for python3t.dll without the directory too
encukou 9dd8cae
Merge in the main branch
encukou 4bc0289
PC/layout: Include python3t in GIL-ful builds
encukou 8b2981e
Build in the abi3t-compat directory
encukou 1cb147a
Build FT to separate directory. Start updating everything that depend…
zooba 555d016
Fix bindpath and simplify some settings
zooba 90681fc
Fix zlib-ng generator and MSI paths
zooba 4bf0990
Add NEWS and update rt.bat
zooba 8529d44
Merge from main
zooba ee8d037
Fix venv
zooba b40f782
Revert unneeded changes
zooba 65d7291
Fix version check for testing
zooba 095886a
Fix comparison
zooba d7eb396
Fix version check
zooba de2da65
Merge from main
zooba 185a6d7
Update tests that build extensions
zooba 57871e9
Satisfy linter
zooba ec2bf28
Maybe satisfy mypy
zooba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Build/2026-05-01-12-01-54.gh-issue-148690.oTtYk-.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Windows free-threaded builds now output to a different default path with | ||
| default filenames, for example, ``PCbuild/amd64t/python.exe`` rather than | ||
| ``PCbuild/amd64/python3.15t.exe``. The ``PC/layout`` script has been updated | ||
| to ensure compatibility of generated layouts. |
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Windows/2026-05-01-12-03-39.gh-issue-148690.TMV8dU.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Non-freethreaded builds on Windows now support extensions linked to | ||
| ``python3t.dll``, and will include a copy of that library in normal installs | ||
| that references the non-freethreaded runtime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.