[3.13] gh-150175: Fix ThreadingMock call_count race condition (GH-150176)#150180
Open
miss-islington wants to merge 1 commit into
Open
[3.13] gh-150175: Fix ThreadingMock call_count race condition (GH-150176)#150180miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…H-150176) ThreadingMock._increment_mock_call() was not thread-safe. Multiple threads calling the mock simultaneously could lose increments due to race conditions on call_count and other attributes. Fix by overriding _increment_mock_call in ThreadingMixin and wrapping it with the existing _mock_calls_events_lock. (cherry picked from commit 388e023) Co-authored-by: saisneha196 <156835592+saisneha196@users.noreply.github.com>
|
The following commit authors need to sign the Contributor License Agreement: |
This was referenced May 21, 2026
Documentation build overview
454 files changed ·
|
Contributor
|
I'm confused, #150176 says CLA was signed, so why the complaint here? |
cjw296
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadingMock._increment_mock_call() was not thread-safe.
Multiple threads calling the mock simultaneously could lose
increments due to race conditions on call_count and other
attributes.
Fix by overriding _increment_mock_call in ThreadingMixin
and wrapping it with the existing _mock_calls_events_lock.
(cherry picked from commit 388e023)
Co-authored-by: saisneha196 156835592+saisneha196@users.noreply.github.com