gh-90980: skip getaddrinfo thread if host is already resolved, using socket.AI_NUMERIC...#31497
Open
graingert wants to merge 7 commits intopython:mainfrom
Open
gh-90980: skip getaddrinfo thread if host is already resolved, using socket.AI_NUMERIC...#31497graingert wants to merge 7 commits intopython:mainfrom
graingert wants to merge 7 commits intopython:mainfrom
Conversation
graingert
commented
Feb 22, 2022
Contributor
Author
There was a problem hiding this comment.
this is inspired by the implementation from trio https://github.com/python-trio/trio/blob/4edfd41bd5519a2e626e87f6c6ca9fb32b90a6f4/trio/_socket.py#L125-L192
graingert
commented
Feb 22, 2022
3ff77cd to
feffb88
Compare
Contributor
Author
|
test_create_connection_ipv6_scope is failing because eg what should |
feffb88 to
5c37749
Compare
5c37749 to
3a87238
Compare
3a87238 to
d305816
Compare
MaxwellDupre
approved these changes
Jul 4, 2022
Contributor
MaxwellDupre
left a comment
There was a problem hiding this comment.
Lets hope comments on slow Mac back in 2015 are resolved. Otherwise a nice optimisation.
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#90980
https://bugs.python.org/issue46824