-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
gh-116241: Add support of multiple inheritance with typing.NamedTuple #31781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
serhiy-storchaka
wants to merge
8
commits into
python:main
Choose a base branch
from
serhiy-storchaka:typing-namedtuple-multiple-inheritance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
939d5f0
bpo-43923: Add support of generic typing.NamedTuple
serhiy-storchaka 64f0c5f
bpo-43923: Add support of multiple inheritance with typing.NamedTuple
serhiy-storchaka d4bc711
Merge branch 'main' into typing-namedtuple-multiple-inheritance
serhiy-storchaka 3159b21
Merge branch 'main' into typing-namedtuple-multiple-inheritance
serhiy-storchaka 9d48f87
Address review comments.
serhiy-storchaka 29dd4b7
Merge branch 'main' into typing-namedtuple-multiple-inheritance
serhiy-storchaka e44773c
Merge branch 'main' into typing-namedtuple-multiple-inheritance
serhiy-storchaka ad78d99
Add also tests for unpacking.
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3016,10 +3016,6 @@ def __new__(cls, typename, bases, ns): | |
| if "__classcell__" in ns: | ||
| raise TypeError( | ||
| "uses of super() and __class__ are unsupported in methods of NamedTuple subclasses") | ||
| for base in bases: | ||
| if base is not _NamedTuple and base is not Generic: | ||
| raise TypeError( | ||
| 'can only inherit from a NamedTuple type and Generic') | ||
|
Comment on lines
-3019
to
-3022
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please consider addressing https://gist.github.com/johnslavik/4d0e22df6cb61868f74269fe7d401f5b. |
||
| bases = tuple(tuple if base is _NamedTuple else base for base in bases) | ||
| if "__annotations__" in ns: | ||
| types = ns["__annotations__"] | ||
|
|
||
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2022-04-28-18-45-58.gh-issue-116241.hu9kRk.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add support for arbitrary multiple inheritance with :class:`typing.NamedTuple`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a test to check the order of the members as well when doing unpacking? And maybe test
class Z(X, Y, NamedTuple)? (I don't know if this leads to a MRO incompatibilty though)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be error. This is tested in the next test.