Skip to content

Commit 4d6be0d

Browse files
committed
Revert "different approach"
This reverts commit 1449c5e.
1 parent ea630b2 commit 4d6be0d

2 files changed

Lines changed: 3 additions & 8 deletions

File tree

mypy/checker.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8338,11 +8338,6 @@ def conditional_types(
83388338
)
83398339
return default, remainder
83408340
if not is_overlapping_types(current_type, proposed_type, ignore_promotions=True):
8341-
if is_overlapping_types(current_type, proposed_type, ignore_promotions=False):
8342-
# Run the check again, taking into account promotions. If the types do overlap,
8343-
# then don't narrow to uninhabited
8344-
return current_type, default
8345-
83468341
# Expression is never of any type in proposed_type_ranges
83478342
return UninhabitedType(), default
83488343
# we can only restrict when the type is precise, not bounded

test-data/unit/check-narrowing.test

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3287,15 +3287,15 @@ from typing import Literal
32873287

32883288
def f1(number: float, i: int):
32893289
if number == i:
3290-
reveal_type(number) # N: Revealed type is "builtins.float"
3290+
reveal_type(number) # N: Revealed type is "builtins.int"
32913291

32923292
def f2(number: float, five: Literal[5]):
32933293
if number == five:
3294-
reveal_type(number) # N: Revealed type is "builtins.float"
3294+
reveal_type(number) # N: Revealed type is "Literal[5]"
32953295

32963296
def f3(number: float | None, i: int):
32973297
if number == i:
3298-
reveal_type(number) # N: Revealed type is "builtins.float"
3298+
reveal_type(number) # N: Revealed type is "builtins.int"
32993299

33003300
def f4(number: float | int, i: int):
33013301
if number == i:

0 commit comments

Comments
 (0)