Enable --sqlite-cache by default (#21041)

Author: hauntsaninja

docs/source/command_line.rst

@@ -1019,9 +1019,10 @@ beyond what incremental mode can offer, try running mypy in
     writing to the cache, use ``--cache-dir=/dev/null`` (UNIX)
     or ``--cache-dir=nul`` (Windows).
 
-.. option:: --sqlite-cache
+.. option:: --no-sqlite-cache
 
-    Use an `SQLite`_ database to store the cache.
+    Avoid using `SQLite`_ database to store the cache, instead write cache data
+    out to individual files.
 
 .. option:: --cache-fine-grained
 

docs/source/config_file.rst

@@ -979,7 +979,7 @@ These options may only be set in the global section (``[mypy]``).
 .. confval:: sqlite_cache
 
     :type: boolean
-    :default: False
+    :default: True
 
     Use an `SQLite`_ database to store the cache.
 

mypy/build.py

@@ -456,9 +456,6 @@ def build_inner(
     # Validate error codes after plugins are loaded.
     options.process_error_codes(error_callback=build_error)
 
-    # Add catch-all .gitignore to cache dir if we created it
-    cache_dir_existed = os.path.isdir(options.cache_dir)
-
     # Construct a build manager object to hold state during the build.
     #
     # Ignore current directory prefix in error messages.
@@ -510,7 +507,7 @@ def build_inner(
         if reports is not None:
             # Finish the HTML or XML reports even if CompileError was raised.
             reports.finish()
-        if not cache_dir_existed and os.path.isdir(options.cache_dir):
+        if os.path.isdir(options.cache_dir):
             add_catch_all_gitignore(options.cache_dir)
             exclude_from_backups(options.cache_dir)
         if os.path.isdir(options.cache_dir):

mypy/metastore.py

@@ -68,6 +68,10 @@ def commit(self) -> None:
     @abstractmethod
     def list_all(self) -> Iterable[str]: ...
 
+    @abstractmethod
+    def close(self) -> None:
+        """Release any resources held by the backing store."""
+
 
 def random_string() -> str:
     return binascii.hexlify(os.urandom(8)).decode("ascii")
@@ -136,6 +140,9 @@ def list_all(self) -> Iterable[str]:
             for file in files:
                 yield os.path.normpath(os_path_join(dir, file))
 
+    def close(self) -> None:
+        pass
+
 
 SCHEMA = """
 CREATE TABLE IF NOT EXISTS files2 (
@@ -224,3 +231,12 @@ def list_all(self) -> Iterable[str]:
         if self.db:
             for row in self.db.execute("SELECT path FROM files2"):
                 yield row[0]
+
+    def close(self) -> None:
+        if self.db:
+            db = self.db
+            self.db = None
+            db.close()
+
+    def __del__(self) -> None:
+        self.close()

mypy/options.py

@@ -299,7 +299,7 @@ def __init__(self) -> None:
         # Caching and incremental checking options
         self.incremental = True
         self.cache_dir = defaults.CACHE_DIR
-        self.sqlite_cache = False
+        self.sqlite_cache = True
         self.fixed_format_cache = True
         self.debug_cache = False
         self.skip_version_check = False

mypy/test/test_ref_info.py

@@ -23,6 +23,7 @@ def run_case(self, testcase: DataDrivenTestCase) -> None:
         options.use_builtins_fixtures = True
         options.show_traceback = True
         options.export_ref_info = True  # This is the flag we are testing
+        options.sqlite_cache = False
 
         src = "\n".join(testcase.input)
         result = build.build(

mypy/test/testcheck.py

@@ -258,6 +258,7 @@ def run_case_once(
                     assert_module_equivalence(
                         "stale" + suffix, expected_stale, res.manager.stale_modules
                     )
+            res.manager.metastore.close()
 
         if testcase.output_files:
             check_test_output_files(testcase, incremental_step, strip_prefix="tmp/")

mypy/test/testexportjson.py

@@ -31,6 +31,7 @@ def run_case(self, testcase: DataDrivenTestCase) -> None:
             options.show_traceback = True
             options.allow_empty_bodies = True
             options.fixed_format_cache = True
+            options.sqlite_cache = False
             fnam = os.path.join(self.base_path, "main.py")
             with open(fnam, "w") as f:
                 f.write(src)

mypyc/codegen/emitmodule.py

@@ -198,13 +198,15 @@ def parse_and_typecheck(
     alt_lib_path: str | None = None,
 ) -> BuildResult:
     assert options.strict_optional, "strict_optional must be turned on"
+    mypyc_plugin = MypycPlugin(options, compiler_options, groups)
     result = build(
         sources=sources,
         options=options,
         alt_lib_path=alt_lib_path,
         fscache=fscache,
-        extra_plugins=[MypycPlugin(options, compiler_options, groups)],
+        extra_plugins=[mypyc_plugin],
     )
+    mypyc_plugin.metastore.close()
     if result.errors:
         raise CompileError(result.errors)
     return result

mypyc/test/test_run.py

@@ -294,6 +294,8 @@ def run_case_step(self, testcase: DataDrivenTestCase, incremental_step: int) ->
             for line in e.messages:
                 print(fix_native_line_number(line, testcase.file, testcase.line))
             assert False, "Compile error"
+        finally:
+            result.manager.metastore.close()
 
         # Check that serialization works on this IR. (Only on the first
         # step because the returned ir only includes updated code.)