Address CR

Author: ilevkivskyi

mypy/build.py

@@ -1084,6 +1084,8 @@ def resolve_location(self, graph: dict[str, State], fullname: str) -> Context |
                 path = state.manager.maybe_swap_for_shadow_path(state.path)
                 source = decode_python_encoding(state.manager.fscache.read(path))
             tree = parse(source, state.path, state.id, state.manager.errors, state.options)
+            # TODO: run first pass of semantic analysis on freshly parsed trees,
+            # we need this to get correct reachability information.
             self.extra_trees[state.id] = tree
         statements = tree.defs
         while prefix:

mypy/traverser.py

@@ -1098,6 +1098,12 @@ def find_definitions(o: Statement, name: str) -> list[Statement]:
 
 
 class DefinitionSeeker(StatementVisitor[None]):
+    """Find only the topmost functions/classes with the given name.
+
+    To find a nested class or method, you should split fullname in parts,
+    and use this visitor for each part.
+    """
+
     def __init__(self, name: str) -> None:
         self.name = name
         self.found: list[Statement] = []
@@ -1150,6 +1156,8 @@ def visit_import_all(self, o: ImportAll, /) -> None:
         pass
 
     def visit_block(self, o: Block, /) -> None:
+        if o.is_unreachable:
+            return
         for s in o.body:
             s.accept(self)
 

test-data/unit/check-incremental.test

@@ -7749,3 +7749,48 @@ tmp/b.py:3: note: "lol" defined here
 [out2]
 tmp/a.py:2: error: Unexpected keyword argument "uhhhh" for "lol"
 tmp/b.py:3: note: "lol" defined here
+
+[case testCachedUnexpectedKeywordArgumentMethod]
+import a
+[file a.py]
+import b
+b.B().lol(uhhhh=12) # tweak
+[file a.py.2]
+import b
+b.B().lol(uhhhh=12)
+[file b.py]
+class A:
+    def lol(self) -> None: pass
+class B:
+    def lol(self) -> None: pass
+class C:
+    def lol(self) -> None: pass
+[out]
+tmp/a.py:2: error: Unexpected keyword argument "uhhhh" for "lol" of "B"
+tmp/b.py:4: note: "lol" of "B" defined here
+[out2]
+tmp/a.py:2: error: Unexpected keyword argument "uhhhh" for "lol" of "B"
+tmp/b.py:4: note: "lol" of "B" defined here
+
+[case testCachedUnexpectedKeywordArgumentMethod2]
+import a
+[file a.py]
+import b
+b.B.BB().lol(uhhhh=12) # tweak
+[file a.py.2]
+import b
+b.B.BB().lol(uhhhh=12)
+[file b.py]
+class A:
+    def lol(self) -> None: pass
+class B:
+    class BB:
+        def lol(self) -> None: pass
+class C:
+    def lol(self) -> None: pass
+[out]
+tmp/a.py:2: error: Unexpected keyword argument "uhhhh" for "lol" of "BB"
+tmp/b.py:5: note: "lol" of "BB" defined here
+[out2]
+tmp/a.py:2: error: Unexpected keyword argument "uhhhh" for "lol" of "BB"
+tmp/b.py:5: note: "lol" of "BB" defined here