Enable --sqlite-cache by default

Author: hauntsaninja

docs/source/command_line.rst

@@ -1019,9 +1019,10 @@ beyond what incremental mode can offer, try running mypy in
     writing to the cache, use ``--cache-dir=/dev/null`` (UNIX)
     or ``--cache-dir=nul`` (Windows).
 
-.. option:: --sqlite-cache
+.. option:: --no-sqlite-cache
 
-    Use an `SQLite`_ database to store the cache.
+    Avoid using `SQLite`_ database to store the cache, instead write cache data
+    out to individual files.
 
 .. option:: --cache-fine-grained
 

docs/source/config_file.rst

@@ -979,7 +979,7 @@ These options may only be set in the global section (``[mypy]``).
 .. confval:: sqlite_cache
 
     :type: boolean
-    :default: False
+    :default: True
 
     Use an `SQLite`_ database to store the cache.
 

mypy/metastore.py

@@ -224,3 +224,12 @@ def list_all(self) -> Iterable[str]:
         if self.db:
             for row in self.db.execute("SELECT path FROM files2"):
                 yield row[0]
+
+    def close(self) -> None:
+        if self.db:
+            db = self.db
+            self.db = None
+            db.close()
+
+    def __del__(self) -> None:
+        self.close()

mypy/options.py

@@ -299,7 +299,7 @@ def __init__(self) -> None:
         # Caching and incremental checking options
         self.incremental = True
         self.cache_dir = defaults.CACHE_DIR
-        self.sqlite_cache = False
+        self.sqlite_cache = True
         self.fixed_format_cache = True
         self.debug_cache = False
         self.skip_version_check = False