Skip to content

Commit a134cb9

Browse files
committed
Set same buffer size for consistency
1 parent 6548a4e commit a134cb9

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

mypy/ipc.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@
1313
import sys
1414
import tempfile
1515
from abc import abstractmethod
16-
from collections.abc import Callable
16+
from collections.abc import Callable, Sequence
1717
from select import select
1818
from types import TracebackType
19-
from typing import Final, Sequence
19+
from typing import Final
2020
from typing_extensions import Self
2121

2222
from librt.base64 import urlsafe_b64encode
@@ -219,6 +219,10 @@ def __init__(self, name: str, timeout: float | None) -> None:
219219
)
220220
else:
221221
self.connection = socket.socket(socket.AF_UNIX)
222+
# This is already default on Linux, we set same buffer size
223+
# for macOS vs Linux consistency to simplify reasoning.
224+
self.connection.setsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF, MAX_READ)
225+
self.connection.setsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF, MAX_READ)
222226
self.connection.settimeout(timeout)
223227
self.connection.connect(name)
224228

@@ -295,6 +299,10 @@ def __enter__(self) -> IPCServer:
295299
else:
296300
try:
297301
self.connection, _ = self.sock.accept()
302+
# This is already default on Linux, we set same buffer size
303+
# for macOS vs Linux consistency to simplify reasoning.
304+
self.connection.setsockopt(socket.SOL_SOCKET, socket.SO_RCVBUF, MAX_READ)
305+
self.connection.setsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF, MAX_READ)
298306
except TimeoutError as e:
299307
raise IPCException("The socket timed out") from e
300308
return self

0 commit comments

Comments
 (0)