Use WAL with SQLite cache, fix close

This is the more modern way to manage concurrency with SQLite

In our case, it means concurrent mypy runs using the cache will wait for
each other, rather than fail

SQLite also claims this is faster, but I haven't yet done a good profile
(If you are profiling this, note that WAL is a persistent setting, so
you will want to delete the cache)

Finally, I also explicitly close the connection in main. This is
relevant to this change, because it forces checkpointing of the WAL,
which reduces disk space and means the cache.db remains a single
self-contained file in regular use

Author: hauntsaninja

mypy/main.py

@@ -189,14 +189,20 @@ def main(
     list([res])  # noqa: C410
 
 
+class BuildResultThunk:
+    # We pass this around so that we avoid freeing memory, which is slow
+    def __init__(self, build_result: build.BuildResult | None) -> None:
+        self._result = build_result
+
+
 def run_build(
     sources: list[BuildSource],
     options: Options,
     fscache: FileSystemCache,
     t0: float,
     stdout: TextIO,
     stderr: TextIO,
-) -> tuple[build.BuildResult | None, list[str], bool]:
+) -> tuple[BuildResultThunk | None, list[str], bool]:
     formatter = util.FancyFormatter(
         stdout, stderr, options.hide_error_codes, hide_success=bool(options.output)
     )
@@ -227,8 +233,12 @@ def flush_errors(filename: str | None, new_messages: list[str], serious: bool) -
         blockers = True
         if not e.use_stdout:
             serious = True
+
+    if res:
+        res.manager.metastore.close()
+
     maybe_write_junit_xml(time.time() - t0, serious, messages, messages_by_file, options)
-    return res, messages, blockers
+    return BuildResultThunk(res), messages, blockers
 
 
 def show_messages(

mypy/metastore.py

@@ -163,6 +163,7 @@ def connect_db(db_file: str, sync_off: bool = False) -> sqlite3.Connection:
         # but without this flag, commits are *very* slow, especially when using HDDs,
         # see https://www.sqlite.org/faq.html#q19 for details.
         db.execute("PRAGMA synchronous=OFF")
+    db.execute("PRAGMA journal_mode=WAL")
     db.executescript(SCHEMA)
     return db