[librt] Add librt.internal API versioning with backward compat#20221
Merged
[librt] Add librt.internal API versioning with backward compat#20221
librt.internal API versioning with backward compat#20221Conversation
…bility This lets us add new API features by adding more functions to the capsule and the module namespace without breaking backward compatibility. We shouldn't use the capsule if the installed version is too old, since we could be calling functions via uninitialized pointers.
Collaborator
Author
|
This requires a librt release after merging. |
Collaborator
Author
|
I guess this will also require an ABI version update. |
Collaborator
Author
|
Similar to #20194, this requires a temporary CI breakage and releasing a new version of librt. I'm planning to merge this and release a new librt version tomorrow (Wed). |
Member
|
Yeah, sure, go ahead when ready. |
JukkaL
added a commit
that referenced
this pull request
Nov 12, 2025
Includes #20221 (which breaks backward compatibility).
JukkaL
added a commit
that referenced
this pull request
Nov 12, 2025
Includes #20221 (which breaks backward compatibility).
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets us add new API features by adding more functions to the capsule and the module namespace without breaking backward compatibility.
We shouldn't use the capsule if the installed version is too old, since we could be calling functions via uninitialized pointers.
Note that this is a breaking change in the
librt.internalABI.