feat: error for Final fields with init=False (#13119)#20382
Open
Benitex wants to merge 2 commits intopython:masterfrom
Open
feat: error for Final fields with init=False (#13119)#20382Benitex wants to merge 2 commits intopython:masterfrom
Benitex wants to merge 2 commits intopython:masterfrom
Conversation
Test cases from PR python#14285, thanks to @jakezych. Co-Authored-By: Jake Zych <56098501+jakezych@users.noreply.github.com> Co-Authored-By: Rafael Christof <rafaeldana@danatelecom.com>
for more information, see https://pre-commit.ci
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds an error report when a dataclass field is declared as
Final, hasinit=False, and lacks a default value, as discussed in Issue #13119. This change adds a check to detect this combination while avoiding complex control flow analysis, as requested. It also flags no error if there's a__post_init__method, to avoid possible false positives.Test cases were adapted from PR #14285. I also added a new test case for default values provided on the field declaration.
Thanks to @jakezych for the original test cases.
Fixes #13119