[mypyc] Raise ValueError if int too big for native int type #20385
Merged
[mypyc] Raise ValueError if int too big for native int type #20385
Conversation
Previously we used OverflowError, which seems inconsistent with CPython, since a conversion/range check is arguably not an arithmetic operation, and OverflowError is a subclass of ArithmeticError. This is an extract for the docs for OverflowError: "Raised when the result of an arithmetic operation is too large to be represented."
p-sawicki
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we used OverflowError, which seems inconsistent with
CPython, since a conversion/range check is arguably not an arithmetic
operation, and OverflowError is a subclass of ArithmeticError.
This is an extract for the docs for OverflowError: "Raised when the result
of an arithmetic operation is too large to be represented."